[iOS] Add Request Mobile Site cell to tools menu

ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h

Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
index 1f7958319fd19e23ec2330f66a33ceb6fc098884..fe7ebe05b459ce20b01fb71da3e6474e60eb9d54 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
@@ -67,12 +67,21 @@ extern NSString* const kToolsMenuReadingListId;
 // can tell that the Tools menu is scrollable.
 - (CGFloat)optimalHeight:(CGFloat)suggestedHeight;
 
+// Hide a menu item by IDC value.
+- (void)hideItemWithTag:(NSInteger)tag;

[kkhorimoto, 2017/02/25 02:36:32]

This is only used from tools_menu_view_controller.mm, so it should be added to
this class's private interface.

[liaoyuke, 2017/02/27 17:34:22]

Acknowledged.

[liaoyuke, 2017/02/27 21:48:59]

Done.

+
 // Enable or disable menu item by IDC value.
 - (void)setItemEnabled:(BOOL)enabled withTag:(NSInteger)tag;
 
 // Called when the current tab loading state changes.
 - (void)setIsTabLoading:(BOOL)isTabLoading;
 
+// Informs tools popup menu to hide "Request Desktop Site" or
+// "Request Mobile Site", note that only one of them is expected to be called
+// at any time.
+- (void)hideRequestDesktopSite;
+- (void)hideRequestMobileSite;

[kkhorimoto, 2017/02/25 02:36:33]

As noted below, let's remove these functions and do the hiding from the
userAgentType setter.

[liaoyuke, 2017/02/27 17:34:22]

Acknowledged.

[liaoyuke, 2017/02/27 21:48:59]

Done.

+
 // TODO(stuartmorgan): Should the set of options that are passed in to the
 // constructor just have the ability to specify whether commands should be
 // enabled or disabled rather than having these individual setters? crbug/228506
@@ -89,6 +98,9 @@ extern NSString* const kToolsMenuReadingListId;
 // Informs tools popup menu whether "Request Desktop Site" can be enabled.
 - (void)setCanUseDesktopUserAgent:(BOOL)value;
 
+// Informs tools popup menu whether "Request Mobile Site" can be enabled.
+- (void)setCanUseMobileUserAgent:(BOOL)value;

[kkhorimoto, 2017/02/25 02:36:33]

Instead of this and the above function, let's just expose a UserAgentType
property corresponding with the UA type of the currently visible page.

@property(nonatomic, assign) web::UserAgentType userAgentType;

Then, in the setter for that property, hide the appropriate option.  For NONE
type (e.g. a native controller, or a tools menu displayed while the tab switcher
is open), we should hide both options.

[liaoyuke, 2017/02/27 17:34:22]

My only concern is that we might be creating unnecessary dependencies, I would
prefer not to have Tools Menu know the existing of web::UserAgentType thing at
all.

+Eugene on this one.

[liaoyuke, 2017/02/27 21:48:59]

Done.

[kkhorimoto, 2017/02/27 23:44:23]

As mentioned in my other comment, because UserAgentType is defined as part of
the public directory, it is okay for any object outside of web// to access it. 
Otherwise, we'd need to store two bools depending on native vs. web pages and
overriding vs. non-overriding UA.

+
 - (void)animateContentIn;
 
 - (void)hideContent;