[iOS] Add Request Mobile Site cell to tools menu

ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_MENU_VIEW_CONTROLLER_H_
 #define IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_MENU_VIEW_CONTROLLER_H_
 
 #import <UIKit/UIKit.h>
 
 @class ToolsMenuContext;
@@ skipping 49 matching lines @@
 - (void)initializeMenu:(ToolsMenuContext*)context;
 
 // Returns the optimal height needed to display the menu items.
 // The height returned is usually less than the |suggestedHeight| unless
 // the last row of the menu puts the height just over the |suggestedHeight|.
 // If the Tools menu items is taller than the |suggestedHeight| by at least
 // one menu item, the last visible menu item will be shown partially so user
 // can tell that the Tools menu is scrollable.
 - (CGFloat)optimalHeight:(CGFloat)suggestedHeight;
 
+// Hide a menu item by IDC value.
+- (void)hideItemWithTag:(NSInteger)tag;

[kkhorimoto, 2017/02/25 02:36:32]

This is only used from tools_menu_view_controller.mm, so it should be added to
this class's private interface.

[liaoyuke, 2017/02/27 17:34:22]

Acknowledged.

[liaoyuke, 2017/02/27 21:48:59]

Done.

+
 // Enable or disable menu item by IDC value.
 - (void)setItemEnabled:(BOOL)enabled withTag:(NSInteger)tag;
 
 // Called when the current tab loading state changes.
 - (void)setIsTabLoading:(BOOL)isTabLoading;
 
+// Informs tools popup menu to hide "Request Desktop Site" or
+// "Request Mobile Site", note that only one of them is expected to be called
+// at any time.
+- (void)hideRequestDesktopSite;
+- (void)hideRequestMobileSite;

[kkhorimoto, 2017/02/25 02:36:33]

As noted below, let's remove these functions and do the hiding from the
userAgentType setter.

[liaoyuke, 2017/02/27 17:34:22]

Acknowledged.

[liaoyuke, 2017/02/27 21:48:59]

Done.

+
 // TODO(stuartmorgan): Should the set of options that are passed in to the
 // constructor just have the ability to specify whether commands should be
 // enabled or disabled rather than having these individual setters? crbug/228506
 // Informs tools popup menu whether "Find In Page..." command should be
 // enabled.
 - (void)setCanShowFindBar:(BOOL)enabled;
 
 // Informs tools popup menu whether "Share..." command should be enabled.
 - (void)setCanShowShareMenu:(BOOL)enabled;
 
 // Informs tools popup menu whether the switch to reader mode is possible.
 - (void)setCanUseReaderMode:(BOOL)enabled;
 
 // Informs tools popup menu whether "Request Desktop Site" can be enabled.
 - (void)setCanUseDesktopUserAgent:(BOOL)value;
 
+// Informs tools popup menu whether "Request Mobile Site" can be enabled.
+- (void)setCanUseMobileUserAgent:(BOOL)value;

[kkhorimoto, 2017/02/25 02:36:33]

Instead of this and the above function, let's just expose a UserAgentType
property corresponding with the UA type of the currently visible page.

@property(nonatomic, assign) web::UserAgentType userAgentType;

Then, in the setter for that property, hide the appropriate option.  For NONE
type (e.g. a native controller, or a tools menu displayed while the tab switcher
is open), we should hide both options.

[liaoyuke, 2017/02/27 17:34:22]

My only concern is that we might be creating unnecessary dependencies, I would
prefer not to have Tools Menu know the existing of web::UserAgentType thing at
all.

+Eugene on this one.

[liaoyuke, 2017/02/27 21:48:59]

Done.

[kkhorimoto, 2017/02/27 23:44:23]

As mentioned in my other comment, because UserAgentType is defined as part of
the public directory, it is okay for any object outside of web// to access it. 
Otherwise, we'd need to store two bools depending on native vs. web pages and
overriding vs. non-overriding UA.

+
 - (void)animateContentIn;
 
 - (void)hideContent;
 
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_MENU_VIEW_CONTROLLER_H_