Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Issue 2714813002: [iOS] Add Request Mobile Site cell to tools menu (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
index e6157e493bbd1ddc227f61e6b8c924c80f2fa7a0..1f055c8e215d12491c2e502228950746264d4370 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
@@ -50,6 +50,7 @@
NSString* const kToolsMenuFindInPageId = @"kToolsMenuFindInPageId";
NSString* const kToolsMenuReaderMode = @"kToolsMenuReaderMode";
NSString* const kToolsMenuRequestDesktopId = @"kToolsMenuRequestDesktopId";
+NSString* const kToolsMenuRequestMobileId = @"kToolsMenuRequestMobileId";
NSString* const kToolsMenuSettingsId = @"kToolsMenuSettingsId";
NSString* const kToolsMenuHelpId = @"kToolsMenuHelpId";
NSString* const kToolsMenuSuggestionsId = @"kToolsMenuSuggestionsId";
@@ -138,6 +139,9 @@ typedef NS_OPTIONS(NSUInteger, kToolbarType) {
{ IDS_IOS_TOOLS_MENU_REQUEST_DESKTOP_SITE, kToolsMenuRequestDesktopId,
IDC_REQUEST_DESKTOP_SITE, kToolbarTypeWebAll,
0, nil },
+ { IDS_IOS_TOOLS_MENU_REQUEST_MOBILE_SITE, kToolsMenuRequestMobileId,
+ IDC_REQUEST_MOBILE_SITE, kToolbarTypeWebAll,
+ 0, nil },
{ IDS_IOS_TOOLS_MENU_READER_MODE, kToolsMenuReaderMode,
IDC_READER_MODE, kToolbarTypeWebAll,
0, nil },
@@ -295,6 +299,16 @@ - (CGFloat)optimalHeight:(CGFloat)suggestedHeight {
}
}
+- (void)hideItemWithTag:(NSInteger)tag {
+ for (ToolsMenuViewItem* item in _menuItems) {
+ if ([item tag] == tag) {
+ [_menuItems removeObject:item];
+ return;
+ }
+ }
+ NOTREACHED();
+}
+
- (void)setItemEnabled:(BOOL)enabled withTag:(NSInteger)tag {
for (ToolsMenuViewItem* item in _menuItems) {
if ([item tag] == tag) {
@@ -324,6 +338,14 @@ - (void)setIsCurrentPageBookmarked:(BOOL)value {
[[toolsCell starredButton] setHidden:!_isCurrentPageBookmarked];
}
+- (void)hideRequestDesktopSite {
+ [self hideItemWithTag:IDC_REQUEST_DESKTOP_SITE];
+}
+
+- (void)hideRequestMobileSite {
+ [self hideItemWithTag:IDC_REQUEST_MOBILE_SITE];
+}
+
- (void)setCanUseReaderMode:(BOOL)enabled {
[self setItemEnabled:enabled withTag:IDC_READER_MODE];
}
@@ -332,6 +354,10 @@ - (void)setCanUseDesktopUserAgent:(BOOL)enabled {
[self setItemEnabled:enabled withTag:IDC_REQUEST_DESKTOP_SITE];
}
+- (void)setCanUseMobileUserAgent:(BOOL)enabled {
+ [self setItemEnabled:enabled withTag:IDC_REQUEST_MOBILE_SITE];
+}
+
- (void)setCanShowFindBar:(BOOL)enabled {
[self setItemEnabled:enabled withTag:IDC_FIND];
}

Powered by Google App Engine
This is Rietveld 408576698