Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2714743002: Retrive displayed notifications asynchronously

Created:
3 years, 10 months ago by Miguel Garcia
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retrive displayed notifications asynchronously DO NOT SUBMIT: This is a proof of concept that will be split into pieces in different CLS BUG=

Patch Set 1 #

Patch Set 2 : apply review comments from https://codereview.chromium.org/2709213005/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -14 lines) Patch
M chrome/browser/notifications/alert_dispatcher_mac.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_display_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_display_service.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/notifications/native_notification_display_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/native_notification_display_service.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_common.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_display_service.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_platform_bridge.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 1 3 chunks +55 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/alert_notification_service.mm View 1 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/notification_delivery.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M content/public/browser/platform_notification_service.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-23 18:57:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714743002/1
3 years, 10 months ago (2017-02-23 18:57:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-23 19:08:14 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 19:08:16 UTC) #4 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698