chrome/browser/notifications/platform_notification_service_impl.h - Issue 2714743002: Retrive displayed notifications asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 2714743002: Retrive displayed notifications asynchronously

Patch Set: apply review comments from https://codereview.chromium.org/2709213005/ Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/platform_notification_service_impl.h

diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h

index 12c6e6181d4190459646c7b7af238fdfbf00576a..cc6865b339c6391ccf2ede2241a710404660dd22 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.h

+++ b/chrome/browser/notifications/platform_notification_service_impl.h

@@ -98,6 +98,9 @@ class PlatformNotificationServiceImpl

bool GetDisplayedNotifications(

content::BrowserContext* browser_context,

std::set<std::string>* displayed_notifications) override;

+ void GetDisplayedNotificationsAsync(

+ content::BrowserContext* browser_context,

+ const NotificationCommon::NotificationResultCallback& callback) override;

private:

friend struct base::DefaultSingletonTraits<PlatformNotificationServiceImpl>;