Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/notifications/notification_platform_bridge_mac.h

Issue 2714743002: Retrive displayed notifications asynchronously
Patch Set: apply review comments from https://codereview.chromium.org/2709213005/ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_ 5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_ 6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 24 matching lines...) Expand all
35 const std::string& notification_id, 35 const std::string& notification_id,
36 const std::string& profile_id, 36 const std::string& profile_id,
37 bool incognito, 37 bool incognito,
38 const Notification& notification) override; 38 const Notification& notification) override;
39 39
40 void Close(const std::string& profile_id, 40 void Close(const std::string& profile_id,
41 const std::string& notification_id) override; 41 const std::string& notification_id) override;
42 bool GetDisplayed(const std::string& profile_id, 42 bool GetDisplayed(const std::string& profile_id,
43 bool incognito, 43 bool incognito,
44 std::set<std::string>* notifications) const override; 44 std::set<std::string>* notifications) const override;
45 void GetDisplayedAsync(const std::string& profile_id,
46 bool incognito,
47 const NotificationCommon::NotificationResultCallback&
48 callback) const override;
45 49
46 // Processes a notification response generated from a user action 50 // Processes a notification response generated from a user action
47 // (click close, etc.). 51 // (click close, etc.).
48 static void ProcessNotificationResponse(NSDictionary* response); 52 static void ProcessNotificationResponse(NSDictionary* response);
49 53
50 // Validates contents of the |response| dictionary as received from the system 54 // Validates contents of the |response| dictionary as received from the system
51 // when a notification gets activated. 55 // when a notification gets activated.
52 static bool VerifyNotificationData(NSDictionary* response) WARN_UNUSED_RESULT; 56 static bool VerifyNotificationData(NSDictionary* response) WARN_UNUSED_RESULT;
53 57
54 private: 58 private:
55 // Cocoa class that receives callbacks from the NSUserNotificationCenter. 59 // Cocoa class that receives callbacks from the NSUserNotificationCenter.
56 base::scoped_nsobject<NotificationCenterDelegate> delegate_; 60 base::scoped_nsobject<NotificationCenterDelegate> delegate_;
57 61
58 // The notification center to use for local banner notifications, 62 // The notification center to use for local banner notifications,
59 // this can be overriden in tests. 63 // this can be overriden in tests.
60 base::scoped_nsobject<NSUserNotificationCenter> notification_center_; 64 base::scoped_nsobject<NSUserNotificationCenter> notification_center_;
61 65
62 // The object in charge of dispatching remote notifications. 66 // The object in charge of dispatching remote notifications.
63 base::scoped_nsprotocol<id<AlertDispatcher>> alert_dispatcher_; 67 base::scoped_nsprotocol<id<AlertDispatcher>> alert_dispatcher_;
64 68
65 DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac); 69 DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac);
66 }; 70 };
67 71
68 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_ 72 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698