Rename cc::ScrollNode's inner and outer viewport members

Rename cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714713003
Cr-Commit-Position: refs/heads/master@{#452897}
Committed: https://chromium.googlesource.com/chromium/src/+/abe15527a4e00dfaefe168f02e387c8c66773285

[pdr., 2017-02-24 00:37:58]

Description was changed from

==========
Refactor cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
==========

to

==========
Refactor cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[pdr., 2017-02-24 00:38:26]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org

[pdr., 2017-02-24 00:38:40]

Description was changed from

==========
Refactor cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[pdr., 2017-02-24 00:38:53]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:39:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 02:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 02:14:58]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-02-24 14:22:34]

lgtm

[pdr., 2017-02-24 19:03:13]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:04:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:16:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487962993041620, "parent_rev":
"9de8877553ac6938ce8ee41222faa0564f63b509", "commit_rev":
"abe15527a4e00dfaefe168f02e387c8c66773285"}

[commit-bot: I haz the power, 2017-02-24 19:16:35]

Description was changed from

==========
Rename cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename cc::ScrollNode's inner and outer viewport members

ScrollNode has members for is_{inner, outer}_viewport_scroll_layer but
these names do not make sense without ScrollNode's owning_layer_id
concept. This patch renames these members to scrolls_inner_viewport
and scrolls_outer_viewport.

In addition, this patch cleans up viewport layer detection added in
https://codereview.chromium.org/2707783003 to use these new members.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714713003
Cr-Commit-Position: refs/heads/master@{#452897}
Committed:
https://chromium.googlesource.com/chromium/src/+/abe15527a4e00dfaefe168f02e38...
==========

[commit-bot: I haz the power, 2017-02-24 19:16:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abe15527a4e00dfaefe168f02e38...