Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2707783003:
Refactor viewport scrolling decisions to use ScrollNodes over layer ids (Closed)
DescriptionRefactor viewport scrolling decisions to use ScrollNodes over layer ids
Viewport scrolling has special-casing that previously used ScrollNode's
owning_layer_id but can be refactored to use ScrollNodes directly.
There should be no change in behavior and this gets us a little closer
to removing owning_layer_id.
BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2707783003
Cr-Commit-Position: refs/heads/master@{#452161}
Committed: https://chromium.googlesource.com/chromium/src/+/dd7a9eede66b8ab6d1b76c24d01010d7ad06cafa
Patch Set 1 #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== Refactor viewport scrolling decisions to use ScrollNodes over layer ids Viewport scrolling has special-casing that previously used ScrollNode's owning_layer_id but can be refactored to use ScrollNodes directly. There should be no change in behavior and this gets us a little closer to removing owning_layer_id. BUG=693740 ========== to ========== Refactor viewport scrolling decisions to use ScrollNodes over layer ids Viewport scrolling has special-casing that previously used ScrollNode's owning_layer_id but can be refactored to use ScrollNodes directly. There should be no change in behavior and this gets us a little closer to removing owning_layer_id. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
pdr@chromium.org changed reviewers: + ajuma@chromium.org
lgtm
The CQ bit was checked by pdr@chromium.org
The CQ bit was unchecked by pdr@chromium.org
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487787134070750, "parent_rev":
"ac719a4ad8dd599eea270444f37a3cc3a05be4a5", "commit_rev":
"dd7a9eede66b8ab6d1b76c24d01010d7ad06cafa"}
Message was sent while issue was closed.
Description was changed from ========== Refactor viewport scrolling decisions to use ScrollNodes over layer ids Viewport scrolling has special-casing that previously used ScrollNode's owning_layer_id but can be refactored to use ScrollNodes directly. There should be no change in behavior and this gets us a little closer to removing owning_layer_id. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Refactor viewport scrolling decisions to use ScrollNodes over layer ids Viewport scrolling has special-casing that previously used ScrollNode's owning_layer_id but can be refactored to use ScrollNodes directly. There should be no change in behavior and this gets us a little closer to removing owning_layer_id. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2707783003 Cr-Commit-Position: refs/heads/master@{#452161} Committed: https://chromium.googlesource.com/chromium/src/+/dd7a9eede66b8ab6d1b76c24d010... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dd7a9eede66b8ab6d1b76c24d010... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
