Make background-image and border-*-style accept CSSKeywordValue('none') as an acceptable value

Make background-image and border-*-style accept CSSKeywordValue('none') as an acceptable value

This patch makes background-image and border-*-style accept
CSSKeywordValue('none') as an acceptable value by editing the
CSSProperties.json5 file.

It also adds the LayoutTest that tests this change.

BUG=691455
Review-Url: https://codereview.chromium.org/2714663002
Cr-Commit-Position: refs/heads/master@{#453889}
Committed: https://chromium.googlesource.com/chromium/src/+/ced73dcd242b3c859323a03a2291d08e3c3f584a

[nainar, 2017-02-23 02:15:33]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-02-23 02:15:56]

nainar@chromium.org changed reviewers:
+ rjwright@chromium.org

[nainar, 2017-02-23 02:15:57]

Renee, 

PTAL? 
Thanks!

[commit-bot: I haz the power, 2017-02-23 02:16:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 04:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 04:16:48]

Dry run: This issue passed the CQ dry run.

[rjwright, 2017-02-23 23:25:36]

On 2017/02/23 02:15:57, nainar wrote:
> Renee, 
> 
> PTAL? 
> Thanks!

lgtm!

[nainar, 2017-02-23 23:26:18]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-02-23 23:26:21]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2017-02-23 23:26:43]

nainar@chromium.org changed reviewers:
+ meade@chromium.org

[nainar, 2017-02-23 23:26:43]

Eddy, 

PTAL? 

Thanks!

[meade_UTC10, 2017-02-27 02:42:07]

https://codereview.chromium.org/2714663002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/set-none-for-properties.html
(right):

https://codereview.chromium.org/2714663002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/set-none-for-properties.html:17:
var propertyArray = ["background-image", "border-top-style",
"border-bottom-style", "border-left-style", "border-right-style"];
The properties directory is supposed to contain all the generated tests for each
property. A couple of options:
1 - (preferred, since that's the direction I'm trying to move these tests) split
this out into 5 tests (one for each property), and use the
runInlineStylePropertyMapTests function to generate the tests
2 - move this up a director

[nainar, 2017-02-27 05:55:41]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 05:55:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-02-27 05:57:00]

https://codereview.chromium.org/2714663002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/set-none-for-properties.html
(right):

https://codereview.chromium.org/2714663002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/set-none-for-properties.html:17:
var propertyArray = ["background-image", "border-top-style",
"border-bottom-style", "border-left-style", "border-right-style"];
Done. Went with option 2

https://codereview.chromium.org/2714663002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/set-none-for-properties.html:17:
var propertyArray = ["background-image", "border-top-style",
"border-bottom-style", "border-left-style", "border-right-style"];
Done.

Went with option 1

[commit-bot: I haz the power, 2017-02-27 06:02:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 06:02:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[meade_UTC10, 2017-03-01 06:36:12]

lgtm

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html
(right):

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html:14:
new CSSURLImageValue(window.location.href+'resources/1x1-green.jpg'),
nit: spaces before and after '+'

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js
(right):

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js:7:
config_templates.borderConfig = {
nit: should we have a TODO or trello task to flesh this out more?

[nainar, 2017-03-01 07:09:00]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 07:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-03-01 07:09:17]

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html
(right):

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html:14:
new CSSURLImageValue(window.location.href+'resources/1x1-green.jpg'),
Done.

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js
(right):

https://codereview.chromium.org/2714663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js:7:
config_templates.borderConfig = {
On 2017/03/01 at 06:36:12, Eddy wrote:
> nit: should we have a TODO or trello task to flesh this out more?

Done. Added a comment and an entry to trello

[nainar, 2017-03-01 07:09:24]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2017-03-01 07:09:26]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-03-01 07:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org, meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2714663002/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-03-01 07:09:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 09:04:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488352166945840,
"parent_rev": "02a3371e8aa5f5ec354509e3625371cbf6f81707", "commit_rev":
"ced73dcd242b3c859323a03a2291d08e3c3f584a"}

[commit-bot: I haz the power, 2017-03-01 09:04:40]

Description was changed from

==========
Make background-image and border-*-style accept CSSKeywordValue('none') as an
acceptable value

This patch makes background-image and border-*-style accept
CSSKeywordValue('none') as an acceptable value by editing the
CSSProperties.json5 file.

It also adds the LayoutTest that tests this change.

BUG=691455
==========

to

==========
Make background-image and border-*-style accept CSSKeywordValue('none') as an
acceptable value

This patch makes background-image and border-*-style accept
CSSKeywordValue('none') as an acceptable value by editing the
CSSProperties.json5 file.

It also adds the LayoutTest that tests this change.

BUG=691455

Review-Url: https://codereview.chromium.org/2714663002
Cr-Commit-Position: refs/heads/master@{#453889}
Committed:
https://chromium.googlesource.com/chromium/src/+/ced73dcd242b3c859323a03a2291...
==========

[commit-bot: I haz the power, 2017-03-01 09:04:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ced73dcd242b3c859323a03a2291...