CSSStyleImageValue::imageLayoutSize() shouldn't crash if no ImageResourceContent

Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if it has no ImageResourceContent

Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if
it has no ImageResourceContent when provided an invalid CSSURLImageValue

Also adds a LayoutTest to test this. 

BUG=691461
Review-Url: https://codereview.chromium.org/2703393012
Cr-Commit-Position: refs/heads/master@{#453892}
Committed: https://chromium.googlesource.com/chromium/src/+/571710acd59dffe9e5fd6fab998282901cd6dcb1

[nainar, 2017-02-24 00:00:36]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:01:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-02-24 00:01:39]

Description was changed from

==========
Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if it has no
ImageResourceContent

Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if
it has no ImageResourceContent when provided an invalid CSSURLImageValue

BUG=691461
==========

to

==========
Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if it has no
ImageResourceContent

Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if
it has no ImageResourceContent when provided an invalid CSSURLImageValue

Also adds a LayoutTest to test this. 

BUG=691461
==========

[nainar, 2017-02-24 00:01:50]

nainar@chromium.org changed reviewers:
+ shans@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:33:42]

Dry run: This issue passed the CQ dry run.

[rune, 2017-02-28 10:52:58]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-02-28 10:52:58]

I haven't studied the spec to tell if this is the right behavior, but otherwise
lgtm.

Please fix the description title to something shorter and keep the full sentence
in the body.

[nainar, 2017-02-28 22:53:30]

On 2017/02/28 at 10:52:58, rune wrote:
> I haven't studied the spec to tell if this is the right behavior, but
otherwise lgtm.
> 
> Please fix the description title to something shorter and keep the full
sentence in the body.

It matches the spec. :)

Strange thing with Reitveld you can't change the title once it is published. It
will show a visual change in Reitveld. But every email from then on will have
the original title. Changing it nonetheless.

FYI: Will probably hold off on this patch
(https://codereview.chromium.org/2714663002) landing so I can merge the two
layout tests together. 

Thank you for the review!

[nainar, 2017-03-01 03:23:13]

On 2017/02/28 at 22:53:30, nainar wrote:
> On 2017/02/28 at 10:52:58, rune wrote:
> > I haven't studied the spec to tell if this is the right behavior, but
otherwise lgtm.
> > 
> > Please fix the description title to something shorter and keep the full
sentence in the body.
> 
> It matches the spec. :)
> 
> Strange thing with Reitveld you can't change the title once it is published.
It will show a visual change in Reitveld. But every email from then on will have
the original title. Changing it nonetheless.
> 
> FYI: Will probably hold off on this patch
(https://codereview.chromium.org/2714663002) landing so I can merge the two
layout tests together. 
> 
> Thank you for the review!

Changed the title of the description.

[nainar, 2017-03-01 07:16:49]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 07:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 08:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 08:53:02]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-03-01 09:12:28]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-03-01 09:12:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2703393012/#ps20001
(title: "Remove file and instead add test to existing file")

[commit-bot: I haz the power, 2017-03-01 09:12:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 09:17:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488359548500810,
"parent_rev": "02b583cc874be794a9772f8b13230ab480058839", "commit_rev":
"571710acd59dffe9e5fd6fab998282901cd6dcb1"}

[commit-bot: I haz the power, 2017-03-01 09:17:45]

Description was changed from

==========
Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if it has no
ImageResourceContent

Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if
it has no ImageResourceContent when provided an invalid CSSURLImageValue

Also adds a LayoutTest to test this. 

BUG=691461
==========

to

==========
Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if it has no
ImageResourceContent

Ensure that CSSStyleImageValue::imageLayoutSize() doesn't crash if
it has no ImageResourceContent when provided an invalid CSSURLImageValue

Also adds a LayoutTest to test this. 

BUG=691461

Review-Url: https://codereview.chromium.org/2703393012
Cr-Commit-Position: refs/heads/master@{#453892}
Committed:
https://chromium.googlesource.com/chromium/src/+/571710acd59dffe9e5fd6fab9982...
==========

[commit-bot: I haz the power, 2017-03-01 09:17:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/571710acd59dffe9e5fd6fab9982...