Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2714583002:
media: Stop sending if-match headers for media fetch requests. (Closed)
Descriptionmedia: Stop sending if-match headers for media fetch requests.
Sending if-match headers disables caching, so stop doing that
until we can think of a better solution.
BUG=689989, 504194
Review-Url: https://codereview.chromium.org/2714583002
Cr-Commit-Position: refs/heads/master@{#452323}
Committed: https://chromium.googlesource.com/chromium/src/+/9974e4f50017f116c3696ce9cc38680e77ac14f1
Patch Set 1 #
Total comments: 1
Patch Set 2 : update comment #
Total comments: 4
Patch Set 3 : comments adressed #
Messages
Total messages: 30 (20 generated)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
hubbe@chromium.org changed reviewers: + tombergan@chromium.org
lgtm https://codereview.chromium.org/2714583002/diff/1/media/blink/resource_multib... File media/blink/resource_multibuffer_data_provider.cc (right): https://codereview.chromium.org/2714583002/diff/1/media/blink/resource_multib... media/blink/resource_multibuffer_data_provider.cc:92: // along the way. See b/504194 and b/689989 for more information. s/b/crbug/ ?
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tombergan@chromium.org Link to the patchset: https://codereview.chromium.org/2714583002/#ps20001 (title: "update comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
hubbe@chromium.org changed reviewers: + dalecurtis@chromium.org - tombergan@chromium.org
dalecurtis@chromium.org changed reviewers: + tombergan@chromium.org
https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... File media/blink/resource_multibuffer_data_provider.cc (right): https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... media/blink/resource_multibuffer_data_provider.cc:93: // if (!url_data_->etag().empty()) { Just delete code? https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... File media/blink/resource_multibuffer_data_provider_unittest.cc (right): https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... media/blink/resource_multibuffer_data_provider_unittest.cc:59: static bool DIABLED_CorrectAcceptEncodingAndEtag( Misspelled. I also don't think this works outside of a TEST_F.
https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... File media/blink/resource_multibuffer_data_provider.cc (right): https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... media/blink/resource_multibuffer_data_provider.cc:93: // if (!url_data_->etag().empty()) { On 2017/02/22 22:43:28, DaleCurtis wrote: > Just delete code? Done. https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... File media/blink/resource_multibuffer_data_provider_unittest.cc (right): https://codereview.chromium.org/2714583002/diff/20001/media/blink/resource_mu... media/blink/resource_multibuffer_data_provider_unittest.cc:59: static bool DIABLED_CorrectAcceptEncodingAndEtag( On 2017/02/22 22:43:28, DaleCurtis wrote: > Misspelled. I also don't think this works outside of a TEST_F. Ops, fixed.
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tombergan@chromium.org Link to the patchset: https://codereview.chromium.org/2714583002/#ps40001 (title: "comments adressed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487806794356840,
"parent_rev": "94bbda5d7cb7bd7a786521d11b0ad1d1d505775c", "commit_rev":
"9974e4f50017f116c3696ce9cc38680e77ac14f1"}
Message was sent while issue was closed.
Description was changed from ========== media: Stop sending if-match headers for media fetch requests. Sending if-match headers disables caching, so stop doing that until we can think of a better solution. BUG=689989, 504194 ========== to ========== media: Stop sending if-match headers for media fetch requests. Sending if-match headers disables caching, so stop doing that until we can think of a better solution. BUG=689989, 504194 Review-Url: https://codereview.chromium.org/2714583002 Cr-Commit-Position: refs/heads/master@{#452323} Committed: https://chromium.googlesource.com/chromium/src/+/9974e4f50017f116c3696ce9cc38... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9974e4f50017f116c3696ce9cc38... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
