media: Stop sending if-match headers for media fetch requests.

media/blink/resource_multibuffer_data_provider_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/resource_multibuffer_data_provider.h"
 
 #include <stdint.h>
 #include <algorithm>
 #include <string>
 #include <utility>
@@ skipping 37 matching lines @@
 const char kHttpRedirect[] = "http://test/ing";
 const char kEtag[] = "\"arglebargle glopy-glyf?\"";
 
 const int kDataSize = 1024;
 const int kHttpOK = 200;
 const int kHttpPartialContent = 206;
 
 enum NetworkState { NONE, LOADED, LOADING };
 
 // Predicate that tests that request disallows compressed data.
-static bool CorrectAcceptEncodingAndEtag(const blink::WebURLRequest& request) {
+// Disabled, see crbug/504194 and crbug/689989 for more information.
+static bool DIABLED_CorrectAcceptEncodingAndEtag(

[DaleCurtis, 2017/02/22 22:43:28]

Misspelled. I also don't think this works outside of a TEST_F.

[hubbe, 2017/02/22 23:13:09]

Ops, fixed.
 

+    const blink::WebURLRequest& request) {
   std::string etag =
       request.httpHeaderField(WebString::fromUTF8("If-Match")).utf8();
   EXPECT_EQ(etag, kEtag);
 
   std::string value =
       request.httpHeaderField(
                  WebString::fromUTF8(net::HttpRequestHeaders::kAcceptEncoding))
           .utf8();
   return (value.find("identity;q=1") != std::string::npos) &&
          (value.find("*;q=0") != std::string::npos);
@@ skipping 259 matching lines @@
 TEST_F(ResourceMultiBufferDataProviderTest, TestRedirects) {
   // Test redirect.
   Initialize(kHttpUrl, 0);
   Start();
   Redirect(kHttpRedirect);
   FullResponse(1024);
   StopWhenLoad();
 }
 
 }  // namespace media