Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2714473002: Move LayoutSVGResourceContainer registration to SVGTreeScopeResources (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayoutSVGResourceContainer registration to SVGTreeScopeResources Move LayoutSVGResourceContainer::registerResource to SVGTreeScopeResources, renaming it to updateResource while getting rid of addResource (since it's only called from updateResource.) Simplify the interaction with the m_pendingResources set a bit, to eliminate a hash-lookup in certain code-paths. BUG=454767 Review-Url: https://codereview.chromium.org/2714473002 Cr-Commit-Position: refs/heads/master@{#452050} Committed: https://chromium.googlesource.com/chromium/src/+/52ef58787c72fbeb70f34c7a16ca6d5e9ab04c10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 3 chunks +5 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp View 2 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 10 months ago (2017-02-22 13:12:14 UTC) #6
Stephen Chennney
lgtm. I'm really happy to see all this resource ID cleanup.
3 years, 10 months ago (2017-02-22 14:56:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714473002/1
3 years, 10 months ago (2017-02-22 15:02:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:06:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52ef58787c72fbeb70f34c7a16ca...

Powered by Google App Engine
This is Rietveld 408576698