Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp

Issue 2714473002: Move LayoutSVGResourceContainer registration to SVGTreeScopeResources (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp b/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
index 2e9430146736804185ff0a18ecc68ce12cc092fa..4cb6f3c050ddf8282d65bece2d78da7fd4999d56 100644
--- a/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
@@ -7,6 +7,7 @@
#include "core/dom/Element.h"
#include "core/dom/TreeScope.h"
#include "core/layout/svg/LayoutSVGResourceContainer.h"
+#include "core/layout/svg/SVGResourcesCache.h"
#include "wtf/text/AtomicString.h"
namespace blink {
@@ -21,13 +22,35 @@ SVGTreeScopeResources::SVGTreeScopeResources(TreeScope* treeScope) {
SVGTreeScopeResources::~SVGTreeScopeResources() = default;
-void SVGTreeScopeResources::addResource(const AtomicString& id,
- LayoutSVGResourceContainer* resource) {
+void SVGTreeScopeResources::updateResource(
+ const AtomicString& id,
+ LayoutSVGResourceContainer* resource) {
DCHECK(resource);
if (id.isEmpty())
return;
- // Replaces resource if already present, to handle potential id changes
+ // Replaces resource if already present, to handle potential id changes.
m_resources.set(id, resource);
+
+ SVGPendingElements* pendingElements = m_pendingResources.take(id);
+ if (!pendingElements)
+ return;
+ // Update cached resources of pending clients.
+ for (Element* clientElement : *pendingElements) {
+ DCHECK(clientElement->hasPendingResources());
+ clearHasPendingResourcesIfPossible(clientElement);
+
+ LayoutObject* layoutObject = clientElement->layoutObject();
+ if (!layoutObject)
+ continue;
+ DCHECK(layoutObject->isSVG());
+
+ StyleDifference diff;
+ diff.setNeedsFullLayout();
+ SVGResourcesCache::clientStyleChanged(layoutObject, diff,
+ layoutObject->styleRef());
+ layoutObject->setNeedsLayoutAndFullPaintInvalidation(
+ LayoutInvalidationReason::SvgResourceInvalidated);
+ }
}
void SVGTreeScopeResources::removeResource(const AtomicString& id) {
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698