Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2714443002: Annotee: Automatically infer host from bootstrap. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
iannucci, nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Annotee: Automatically infer host from bootstrap. If a Butler bootstrap is provided, have Annotee automatically infer the LogDog Coordinator host from the bootstrap. When Annotee was originally written, the bootstrap didn't contain this information. BUG=chromium:694911 TEST=None Review-Url: https://codereview.chromium.org/2714443002 Committed: https://github.com/luci/luci-go/commit/63725204857b1212bc56d1b088980df1bc903026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M logdog/client/cmd/logdog_annotee/main.go View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 10 months ago (2017-02-22 06:31:46 UTC) #2
nodir
lgtm
3 years, 10 months ago (2017-02-22 17:53:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714443002/1
3 years, 10 months ago (2017-02-22 17:56:46 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:02:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/63725204857b1212bc56d1b088980df1bc903026

Powered by Google App Engine
This is Rietveld 408576698