Butler: Infer host from "coordinator-host" flag.

Butler: Infer host from "coordinator-host" flag.

Currently, the LogDog Coordinator host can be explicitly specified as a
top-level flag. This is redundant with the host, which is also specified
in the LogDog "output" module.

The reason for this is that some configurations may wish to direct the
Butler to a services module within the host (e.g., service-dot-example.com).
However, the host must still be available for viewer link generation.

Rather than specify it multiple times, we will use only the top-level
host flag. The production output, "logdog", can take an additional optional
service name which, if provided, can be used to construct the
"service-dot-host" host for service engagement.

BUG=chromium:694911
TEST=None

Review-Url: https://codereview.chromium.org/2715443002
Committed: https://github.com/luci/luci-go/commit/715bd11e4c5717e9b5fa7da0c547638bbd9a3f87

[dnj, 2017-02-22 06:31:39]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, nodir@chromium.org

[dnj, 2017-02-22 06:31:39]

PTAL

[nodir, 2017-02-22 17:25:22]

lgtm

GAE terminology changed: modules are now called services

[dnj, 2017-02-22 17:46:51]

Description was changed from

==========
Butler: Infer host from "coordinator-host" flag.

Currently, the LogDog Coordinator host can be explicitly specified as a
top-level flag. This is redundant with the host, which is also specified
in the LogDog "output" module.

The reason for this is that some configurations may wish to direct the
Butler to a services module within the host (e.g., service-dot-example.com).
However, the host must still be available for viewer link generation.

Rather than specify it multiple times, we will use only the top-level
host flag. The production output, "logdog", can take an additional optional
module name which, if provided, can be used to construct the
"service-dot-host" host for service engagement.

BUG=chromium:694911
TEST=None
==========

to

==========
Butler: Infer host from "coordinator-host" flag.

Currently, the LogDog Coordinator host can be explicitly specified as a
top-level flag. This is redundant with the host, which is also specified
in the LogDog "output" module.

The reason for this is that some configurations may wish to direct the
Butler to a services module within the host (e.g., service-dot-example.com).
However, the host must still be available for viewer link generation.

Rather than specify it multiple times, we will use only the top-level
host flag. The production output, "logdog", can take an additional optional
service name which, if provided, can be used to construct the
"service-dot-host" host for service engagement.

BUG=chromium:694911
TEST=None
==========

[dnj, 2017-02-22 17:46:54]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-02-22 17:46:54]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2715443002/#ps20001
(title: "module => service")

[commit-bot: I haz the power, 2017-02-22 17:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:52:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487785614288740,
"parent_rev": "7e123ef96d5a134b8864271e2db68bcbad3e0036", "commit_rev":
"715bd11e4c5717e9b5fa7da0c547638bbd9a3f87"}

[commit-bot: I haz the power, 2017-02-22 17:53:02]

Description was changed from

==========
Butler: Infer host from "coordinator-host" flag.

Currently, the LogDog Coordinator host can be explicitly specified as a
top-level flag. This is redundant with the host, which is also specified
in the LogDog "output" module.

The reason for this is that some configurations may wish to direct the
Butler to a services module within the host (e.g., service-dot-example.com).
However, the host must still be available for viewer link generation.

Rather than specify it multiple times, we will use only the top-level
host flag. The production output, "logdog", can take an additional optional
service name which, if provided, can be used to construct the
"service-dot-host" host for service engagement.

BUG=chromium:694911
TEST=None
==========

to

==========
Butler: Infer host from "coordinator-host" flag.

Currently, the LogDog Coordinator host can be explicitly specified as a
top-level flag. This is redundant with the host, which is also specified
in the LogDog "output" module.

The reason for this is that some configurations may wish to direct the
Butler to a services module within the host (e.g., service-dot-example.com).
However, the host must still be available for viewer link generation.

Rather than specify it multiple times, we will use only the top-level
host flag. The production output, "logdog", can take an additional optional
service name which, if provided, can be used to construct the
"service-dot-host" host for service engagement.

BUG=chromium:694911
TEST=None

Review-Url: https://codereview.chromium.org/2715443002
Committed:
https://github.com/luci/luci-go/commit/715bd11e4c5717e9b5fa7da0c547638bbd9a3f87
==========

[commit-bot: I haz the power, 2017-02-22 17:53:03]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/715bd11e4c5717e9b5fa7da0c547638bbd9a3f87