Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2714403002: Revert of Check whether ScriptResource is still loading due to revalidation (Closed)

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, loading-reviews_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check whether ScriptResource is still loading due to revalidation (patchset #2 id:20001 of https://codereview.chromium.org/2706303002/ ) Reason for revert: Sufficient data are collected and thus finishing the investigation. BUG=696305 Original issue's description: > Check whether ScriptResource is still loading due to revalidation > > ScriptResource is assumed to be already loaded when it is used by > ScriptResource::script() and PendingScript. > However, there might slight chances that isLoaded() is false due to > revalidation, possibly causing Issue 692856. > > In order to check whether and how often revalidation can cause > isLoaded() to be false in existing DCHECK()s, this CL replaces > DCHECK(isLoaded()) with three CHECK()s, each of which fails when: > 1. isLoaded() is false not because of revalidation, > 2. isLoaded() is false because revalidation is ongoing and response is > already received, and > 3. isLoaded() is false because revalidation is ongoing and response is > not yet received. > > BUG=692856 > > Review-Url: https://codereview.chromium.org/2706303002 > Cr-Commit-Position: refs/heads/master@{#453057} > Committed: https://chromium.googlesource.com/chromium/src/+/6dc58b5746363ddbb99addb4c06c69a385212b7d TBR=japhet@chromium.org,kouhei@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=692856 Review-Url: https://codereview.chromium.org/2714403002 Cr-Commit-Position: refs/heads/master@{#453150} Committed: https://chromium.googlesource.com/chromium/src/+/4c7dd9f84d0f9b306bea368e4015fae01fcd6541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
hiroshige
Created Revert of Check whether ScriptResource is still loading due to revalidation
3 years, 9 months ago (2017-02-27 03:18:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714403002/1
3 years, 9 months ago (2017-02-27 03:18:40 UTC) #3
kouhei (in TOK)
lgtm
3 years, 9 months ago (2017-02-27 03:22:43 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 04:53:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c7dd9f84d0f9b306bea368e4015...

Powered by Google App Engine
This is Rietveld 408576698