Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2714133003: bindings: Remove usages of restricted_float in the Python code. (Closed)

Created:
3 years, 10 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Remove usages of restricted_float in the Python code. This argument was present in several functions, but its value was not being used anywhere since 2015's https://codereview.chromium.org/970843002 ("IDL: Implement float/double correctly"). R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2714133003 Cr-Commit-Position: refs/heads/master@{#453084} Committed: https://chromium.googlesource.com/chromium/src/+/9c02e0c421a5d06d7acc5bae646c40e149b65989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_methods.py View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_union.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Raphael Kubo da Costa (rakuco)
PTAL. This is a small cleanup I've found while working on https://codereview.chromium.org/2709983004/
3 years, 10 months ago (2017-02-24 13:37:04 UTC) #1
haraken
LGTM
3 years, 10 months ago (2017-02-25 00:26:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714133003/1
3 years, 10 months ago (2017-02-25 10:07:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9c02e0c421a5d06d7acc5bae646c40e149b65989
3 years, 10 months ago (2017-02-25 12:17:24 UTC) #7
Yuki
3 years, 9 months ago (2017-03-01 09:08:54 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698