Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 970843002: IDL: Implement float/double correctly (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Implement float/double correctly Specifically, do not require the [TypeChecking=Unrestricted] extended attribute for correct behavior. This renders the [TypeChecking=Unrestricted] extended attribute ineffective, meaning we can then drop it from actual IDL files without code generation changes. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -39 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 2 chunks +1 line, -5 lines 0 comments Download
M Source/bindings/scripts/v8_dictionary.py View 2 chunks +1 line, -6 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 2 chunks +1 line, -5 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Jens Widell
PTAL There are no code generation changes (once the ScrollToOptions CL lands). I plan to ...
5 years, 9 months ago (2015-03-02 10:21:23 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-02 10:54:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970843002/1
5 years, 9 months ago (2015-03-02 13:05:28 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 15:30:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191108

Powered by Google App Engine
This is Rietveld 408576698