views: don't try to SetProperty on NSWindows

views: don't try to SetProperty on NSWindows

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None

Review-Url: https://codereview.chromium.org/2714063003
Cr-Commit-Position: refs/heads/master@{#453218}
Committed: https://chromium.googlesource.com/chromium/src/+/3d421af6056a88ae9516c1b4fae5b30f716aba45

[Elly Fong-Jones, 2017-02-24 16:27:27]

Description was changed from

==========
views: don't try to SetProperty on NSWindows

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None
==========

to

==========
views: don't try to SetProperty on NSWindows

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None
==========

[Elly Fong-Jones, 2017-02-24 16:27:27]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2017-02-24 16:27:37]

sky: ptal?

cc kylixrd and sdy

[sky, 2017-02-24 18:35:16]

LGTM

https://codereview.chromium.org/2714063003/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_window_factory.cc (right):

https://codereview.chromium.org/2714063003/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_window_factory.cc:28:
view->GetWidget()->GetNativeWindow()->SetProperty(
An alternative is to call view->GetWidget()->SetNativeProperty(). That said, I
think the user gesture isn't needed on mac, so I'm ok with this fix. That said,
please put the aura includes in an ifdef aura as well.

[Elly Fong-Jones, 2017-02-24 18:57:57]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-02-24 18:57:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2714063003/#ps20001
(title: "more #if defined")

[commit-bot: I haz the power, 2017-02-24 18:58:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 20:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:01:18]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elly Fong-Jones, 2017-02-27 14:50:10]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2017-02-27 14:50:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 15:38:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488207010830210,
"parent_rev": "2c3d3754fd0305eb1c9f092efc7ce49fa76d8630", "commit_rev":
"3d421af6056a88ae9516c1b4fae5b30f716aba45"}

[commit-bot: I haz the power, 2017-02-27 15:39:12]

Description was changed from

==========
views: don't try to SetProperty on NSWindows

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None
==========

to

==========
views: don't try to SetProperty on NSWindows

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None

Review-Url: https://codereview.chromium.org/2714063003
Cr-Commit-Position: refs/heads/master@{#453218}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d421af6056a88ae9516c1b4fae5...
==========

[commit-bot: I haz the power, 2017-02-27 15:39:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d421af6056a88ae9516c1b4fae5...