views: don't try to SetProperty on NSWindows

chrome/browser/ui/views/frame/browser_window_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/native_browser_frame_factory.h"
 #include "chrome/grit/chromium_strings.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/widget/widget.h"
 
 // static
 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser,
                                                   bool user_gesture) {
   // Create the view and the frame. The frame will attach itself via the view
   // so we don't need to do anything with the pointer.
   BrowserView* view = new BrowserView();
   view->Init(browser);
   (new BrowserFrame(view))->InitBrowserFrame();
   view->GetWidget()->non_client_view()->SetAccessibleName(
       l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
-  // For now, all browser windows are true.
+
+#if defined(USE_AURA)
+  // For now, all browser windows are true. This only works when USE_AURA
+  // because it requires gfx::NativeWindow to be an aura::Window*.
   view->GetWidget()->GetNativeWindow()->SetProperty(

[sky, 2017/02/24 18:35:16]

An alternative is to call view->GetWidget()->SetNativeProperty(). That said, I
think the user gesture isn't needed on mac, so I'm ok with this fix. That said,
please put the aura includes in an ifdef aura as well.

       aura::client::kCreatedByUserGesture, user_gesture);
+#endif
   return view;
 }