Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2713993003: Revert of build: Enable auto raw pointer deduction check on linux. (Closed)

Created:
3 years, 10 months ago by vmpstr
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of build: Enable auto raw pointer deduction check on linux. (patchset #2 id:20001 of https://codereview.chromium.org/2697873004/ ) Reason for revert: Build failure as a result of the flag. I will fix up and reland. Original issue's description: > build: Enable auto raw pointer deduction check on linux. > > This patch enables the auto raw pointer deduction on linux. The plan > is to also enable this on all the remaining platforms shortly. > > R=thakis@chromium.org, danakj@chromium.org > BUG=554600 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2697873004 > Cr-Commit-Position: refs/heads/master@{#452880} > Committed: https://chromium.googlesource.com/chromium/src/+/4075255b128597153622d38d72286ff223d64f33 TBR=jochen@chromium.org,dalecurtis@chromium.org,danakj@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554600 Review-Url: https://codereview.chromium.org/2713993003 Cr-Commit-Position: refs/heads/master@{#452892} Committed: https://chromium.googlesource.com/chromium/src/+/5187e38a974a9346dd330efc5802888d9b0d1f21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M build/config/clang/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cryptauth/fake_secure_channel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher_helper_posix.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/base/demuxer_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vmpstr
Created Revert of build: Enable auto raw pointer deduction check on linux.
3 years, 10 months ago (2017-02-24 19:02:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713993003/1
3 years, 10 months ago (2017-02-24 19:03:23 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 19:08:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5187e38a974a9346dd330efc5802...

Powered by Google App Engine
This is Rietveld 408576698