Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2697873004: build: Enable auto raw pointer deduction check on linux. (Closed)

Created:
3 years, 10 months ago by vmpstr
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Enable auto raw pointer deduction check on linux. This patch enables the auto raw pointer deduction on linux. The plan is to also enable this on all the remaining platforms shortly. R=thakis@chromium.org, danakj@chromium.org BUG=554600 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2697873004 Cr-Commit-Position: refs/heads/master@{#452973} Committed: https://chromium.googlesource.com/chromium/src/+/c2a957c63637a55bb157b2cb24d2f3b5fce206d9

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M build/config/clang/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/cryptauth/fake_secure_channel.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestion_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/in_memory_url_index_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher_helper_posix.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M media/base/demuxer_perftest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_resource.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/renderer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (23 generated)
vmpstr
Please take a look. This won't pass trybots until https://codereview.chromium.org/2691393002/ lands
3 years, 10 months ago (2017-02-15 20:57:12 UTC) #1
danakj
LGTM
3 years, 10 months ago (2017-02-15 21:17:48 UTC) #2
Nico
lgtm, good luck!
3 years, 10 months ago (2017-02-15 21:43:19 UTC) #3
vmpstr
Hello, it took about a week to land the changes to fix all linux problems ...
3 years, 10 months ago (2017-02-23 22:10:05 UTC) #11
danakj
LGTM if u have trouble with the CQ u might wanna split it again, up ...
3 years, 10 months ago (2017-02-23 23:55:52 UTC) #12
vmpstr
+dalecurtis for media/ +jochen for components/ and content/ Please take a look. These are largely ...
3 years, 10 months ago (2017-02-24 00:27:47 UTC) #14
DaleCurtis
media/ lgtm
3 years, 10 months ago (2017-02-24 00:29:39 UTC) #15
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-24 15:58:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697873004/20001
3 years, 10 months ago (2017-02-24 18:34:41 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4075255b128597153622d38d72286ff223d64f33
3 years, 10 months ago (2017-02-24 18:41:41 UTC) #24
vmpstr
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2713993003/ by vmpstr@chromium.org. ...
3 years, 10 months ago (2017-02-24 19:02:30 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697873004/40001
3 years, 10 months ago (2017-02-24 22:02:05 UTC) #33
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 22:55:26 UTC) #36
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c2a957c63637a55bb157b2cb24d2...

Powered by Google App Engine
This is Rietveld 408576698