Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chromecast/crash/cast_crash_keys.h

Issue 2713843003: [Chromecast] Don't override RegisterCrashKeys() on Android. (Closed)
Patch Set: Remove RegisterCastCrashKeys() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/app/android/cast_crash_reporter_client_android.cc ('k') | chromecast/crash/cast_crash_keys.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/cast_crash_keys.h
diff --git a/chromecast/crash/cast_crash_keys.h b/chromecast/crash/cast_crash_keys.h
index 13063846f9cce70121ad3f6a991ad8dcc5824d77..a8f8299daf7a67ec6cc3f2ecdfa2305a8b070ae0 100644
--- a/chromecast/crash/cast_crash_keys.h
+++ b/chromecast/crash/cast_crash_keys.h
@@ -12,7 +12,17 @@
namespace chromecast {
namespace crash_keys {
-size_t RegisterCastCrashKeys();
+// TODO(slan|sanfin): Currently, the crash keys are unused on Cast. Without
+// calling base::debug::InitCrashKeys(), all calls to set crash key values are
+// no-ops.
+//
+// One problem with registering the crash keys here is that other modules have
+// their keys registered in chrome/common/crash_keys.cc, and if that file
+// changes without also updating our own registration function, we will
+// encounter crashes.
+//
+// crbug.com/598854 tracks an effort to allow componentizing crash key
+// definitions so we can remove this implicit dependency on //chrome.
extern const char kCurrentApp[];
extern const char kLastApp[];
« no previous file with comments | « chromecast/app/android/cast_crash_reporter_client_android.cc ('k') | chromecast/crash/cast_crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698