Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5951)

Unified Diff: chromecast/crash/cast_crash_keys.cc

Issue 2713843003: [Chromecast] Don't override RegisterCrashKeys() on Android. (Closed)
Patch Set: Remove RegisterCastCrashKeys() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/cast_crash_keys.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/cast_crash_keys.cc
diff --git a/chromecast/crash/cast_crash_keys.cc b/chromecast/crash/cast_crash_keys.cc
index 7de30624b3afe6ec9b0b6d63421da2ca3bf06670..5cec71ce1fb888a1a50f64c11cd2dd85b43f06b3 100644
--- a/chromecast/crash/cast_crash_keys.cc
+++ b/chromecast/crash/cast_crash_keys.cc
@@ -5,8 +5,6 @@
#include "base/macros.h"
#include "chromecast/crash/cast_crash_keys.h"
-// TODO(kjoswiak): Potentially refactor chunk size info as well as non-cast
-// specific keys out and make shared with chrome/common/crash_keys.cc.
namespace {
// A small crash key, guaranteed to never be split into multiple pieces.
@@ -33,85 +31,5 @@ const char kLastApp[] = "last_app";
const char kCurrentApp[] = "current_app";
const char kPreviousApp[] = "previous_app";
-size_t RegisterCastCrashKeys() {
- const base::debug::CrashKey fixed_keys[] = {
- { kLastApp, kSmallSize },
- { kCurrentApp, kSmallSize },
- { kPreviousApp, kSmallSize },
- // content/:
- { "discardable-memory-allocated", kSmallSize },
- { "discardable-memory-free", kSmallSize },
- { "ppapi_path", kMediumSize },
- { "subresource_url", kLargeSize },
- { "total-discardable-memory-allocated", kSmallSize },
-
- // gin/:
- { "v8-ignition", kSmallSize },
-
- // Copied from common/crash_keys. Remove when
- // http://crbug.com/598854 is resolved.
-
- // Temporary for http://crbug.com/575245
- { "swapout_frame_id", kSmallSize },
- { "swapout_proxy_id", kSmallSize },
- { "swapout_view_id", kSmallSize },
- { "commit_frame_id", kSmallSize },
- { "commit_proxy_id", kSmallSize },
- { "commit_view_id", kSmallSize },
- { "commit_main_render_frame_id", kSmallSize },
- { "newproxy_proxy_id", kSmallSize },
- { "newproxy_view_id", kSmallSize },
- { "newproxy_opener_id", kSmallSize },
- { "newproxy_parent_id", kSmallSize },
- { "rvinit_view_id", kSmallSize },
- { "rvinit_proxy_id", kSmallSize },
- { "rvinit_main_frame_id", kSmallSize },
- { "initrf_frame_id", kSmallSize },
- { "initrf_proxy_id", kSmallSize },
- { "initrf_view_id", kSmallSize },
- { "initrf_main_frame_id", kSmallSize },
- { "initrf_view_is_live", kSmallSize },
-
- // Keys for https://crbug.com/591478
- { "initrf_parent_proxy_exists", kSmallSize },
- { "initrf_render_view_is_live", kSmallSize },
- { "initrf_parent_is_in_same_site_instance", kSmallSize},
- { "initrf_parent_process_is_live", kSmallSize},
- { "initrf_root_is_in_same_site_instance", kSmallSize},
- { "initrf_root_is_in_same_site_instance_as_parent", kSmallSize},
- { "initrf_root_process_is_live", kSmallSize},
- { "initrf_root_proxy_is_live", kSmallSize},
-
- // Temporary for https://crbug.com/626802.
- { "newframe_routing_id", kSmallSize },
- { "newframe_proxy_id", kSmallSize },
- { "newframe_opener_id", kSmallSize },
- { "newframe_parent_id", kSmallSize },
- { "newframe_widget_id", kSmallSize },
- { "newframe_widget_hidden", kSmallSize },
- { "newframe_replicated_origin", kSmallSize },
- { "newframe_oopifs_possible", kSmallSize },
-
- // Temporary for https://crbug.com/630103.
- { "origin_mismatch_url", kLargeSize },
- { "origin_mismatch_origin", kMediumSize },
- { "origin_mismatch_transition", kSmallSize },
- { "origin_mismatch_redirects", kSmallSize },
- { "origin_mismatch_same_page", kSmallSize },
-
- // Temporary for https://crbug.com/612711.
- { "aci_wrong_sp_extension_id", kSmallSize },
-
- // Temporary for https://crbug.com/668633.
- { "swdh_set_hosted_version_worker_pid", kSmallSize },
- { "swdh_set_hosted_version_host_pid", kSmallSize },
- { "swdh_set_hosted_version_is_new_process", kSmallSize },
- { "swdh_set_hosted_version_restart_count", kSmallSize },
- };
-
- return base::debug::InitCrashKeys(fixed_keys, arraysize(fixed_keys),
- kChunkMaxLength);
-}
-
} // namespace crash_keys
} // namespace chromecast
« no previous file with comments | « chromecast/crash/cast_crash_keys.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698