Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chromecast/crash/cast_crash_keys.h

Issue 2713843003: [Chromecast] Don't override RegisterCrashKeys() on Android. (Closed)
Patch Set: Remove RegisterCastCrashKeys() Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_CRASH_CAST_CRASH_KEYS_H_ 5 #ifndef CHROMECAST_CRASH_CAST_CRASH_KEYS_H_
6 #define CHROMECAST_CRASH_CAST_CRASH_KEYS_H_ 6 #define CHROMECAST_CRASH_CAST_CRASH_KEYS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "base/debug/crash_logging.h" 10 #include "base/debug/crash_logging.h"
11 11
12 namespace chromecast { 12 namespace chromecast {
13 namespace crash_keys { 13 namespace crash_keys {
14 14
15 size_t RegisterCastCrashKeys(); 15 // TODO(slan|sanfin): Currently, the crash keys are unused on Cast. Without
16 // calling base::debug::InitCrashKeys(), all calls to set crash key values are
17 // no-ops.
18 //
19 // One problem with registering the crash keys here is that other modules have
20 // their keys registered in chrome/common/crash_keys.cc, and if that file
21 // changes without also updating our own registration function, we will
22 // encounter crashes.
23 //
24 // crbug.com/598854 tracks an effort to allow componentizing crash key
25 // definitions so we can remove this implicit dependency on //chrome.
16 26
17 extern const char kCurrentApp[]; 27 extern const char kCurrentApp[];
18 extern const char kLastApp[]; 28 extern const char kLastApp[];
19 extern const char kPreviousApp[]; 29 extern const char kPreviousApp[];
20 30
21 } // namespace chromecast 31 } // namespace chromecast
22 } // namespace crash_keys 32 } // namespace crash_keys
23 33
24 #endif // CHROMECAST_CRASH_CAST_CRASH_KEYS_H_ 34 #endif // CHROMECAST_CRASH_CAST_CRASH_KEYS_H_
OLDNEW
« no previous file with comments | « chromecast/app/android/cast_crash_reporter_client_android.cc ('k') | chromecast/crash/cast_crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698