Remove and hide analyzer cli flags.

Remove and hide analyzer cli flags.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1da570c21576a7cb40388d1ea20d326c0f7f8adf

[devoncarew, 2017-02-22 21:52:06]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com

[devoncarew, 2017-02-22 21:52:06]

Final round of analyzer cli flags cleanup:
- replace --show-sdk-warnings and --warnings with --sdk-warnings (for similarity
with --package-warnings)
- make --sdk-warnings hidden (users generally won't need this option)
- remove the deprecated --show-package-warnings (we just have --package-warnings
now)

The CLI -h output now looks like:

Usage: dartanalyzer [options...] <directory or list of files>

    --dart-sdk               The path to the Dart SDK.
    --options                Path to an analysis options file.
    --package-root           The path to a package root directory (deprecated).
This option cannot be used with --packages.
    --[no-]strong            Enable strong static checks
(https://goo.gl/DqcBsw).
    --no-implicit-casts      Disable implicit casts in strong mode
(https://goo.gl/cTLz40).
    --no-implicit-dynamic    Disable implicit dynamic (https://goo.gl/m0UgXD).
    --packages               The path to the package resolution configuration
file, which supplies a mapping of package names
                             to paths. This option cannot be used with
--package-root.

    --format                 Specifies the format in which errors are displayed;
the only currently allowed value is 'machine'.
    --version                Print the analyzer version.
    --lints                  Show lint results.
    --no-hints               Do not show hint results.
    --fatal-hints            Treat hints as fatal.
    --fatal-warnings         Treat non-type warnings as fatal.
    --fatal-lints            Treat lints as fatal.
    --package-warnings       Show warnings from package: imports.
-h, --help                   Display this help message. Add --verbose to show
hidden options.
-v, --verbose                Verbose output.

Run "dartanalyzer -h -v" for verbose help output, including less commonly used
options.
For more information, see http://www.dartlang.org/tools/analyzer.

[Brian Wilkerson, 2017-02-22 22:01:59]

lgtm

https://codereview.chromium.org/2713723003/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/2713723003/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:410: ..addFlag('show-package-warnings',
"remove the deprecated --show-package-warnings" - it doesn't look like it was
removed.

[devoncarew, 2017-02-22 22:07:43]

https://codereview.chromium.org/2713723003/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/2713723003/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:410: ..addFlag('show-package-warnings',
On 2017/02/22 22:01:59, Brian Wilkerson wrote:
> "remove the deprecated --show-package-warnings" - it doesn't look like it was
> removed.

ack - this should have read "hide --show-package-warnings". I kept it for (some)
consistency with the dart2js flag.

[devoncarew, 2017-02-22 22:09:45]

Description was changed from

==========
Remove and hide analyzer cli flags.

BUG=
==========

to

==========
Remove and hide analyzer cli flags.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1da570c21576a7cb40388d1ea20d326c0f7f8adf
==========

[devoncarew, 2017-02-22 22:09:46]

Committed patchset #1 (id:1) manually as
1da570c21576a7cb40388d1ea20d326c0f7f8adf (presubmit successful).