Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: pkg/analyzer_cli/lib/src/options.dart

Issue 2713723003: Remove and hide analyzer cli flags. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/README.md ('k') | pkg/analyzer_cli/test/options_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/options.dart
diff --git a/pkg/analyzer_cli/lib/src/options.dart b/pkg/analyzer_cli/lib/src/options.dart
index 19363fd14537cdc71e3579dc801f74d51e490969..d1550c30f5a889d3bc2a46bf4e023011b23e6ae7 100644
--- a/pkg/analyzer_cli/lib/src/options.dart
+++ b/pkg/analyzer_cli/lib/src/options.dart
@@ -172,7 +172,7 @@ class CommandLineOptions {
args['package-warnings'] ||
args['x-package-warnings-prefix'] != null,
showPackageWarningsPrefix = args['x-package-warnings-prefix'],
- showSdkWarnings = args['show-sdk-warnings'] || args['warnings'],
+ showSdkWarnings = args['sdk-warnings'],
sourceFiles = args.rest,
warningsAreFatal = args['fatal-warnings'],
strongMode = args['strong'],
@@ -315,18 +315,6 @@ class CommandLineOptions {
help: 'Show warnings from package: imports.',
defaultsTo: false,
negatable: false)
- ..addFlag('show-package-warnings',
- help: 'Show warnings from package: imports (deprecated).',
- defaultsTo: false,
- negatable: false)
- ..addFlag('warnings',
- help: 'Show warnings from SDK imports.',
- defaultsTo: false,
- negatable: false)
- ..addFlag('show-sdk-warnings',
- help: 'Show warnings from SDK imports (deprecated).',
- defaultsTo: false,
- negatable: false)
..addFlag('help',
abbr: 'h',
help:
@@ -419,6 +407,16 @@ class CommandLineOptions {
defaultsTo: false,
negatable: false,
hide: hide)
+ ..addFlag('show-package-warnings',
Brian Wilkerson 2017/02/22 22:01:59 "remove the deprecated --show-package-warnings" -
devoncarew 2017/02/22 22:07:43 ack - this should have read "hide --show-package-w
+ help: 'Show warnings from package: imports (deprecated).',
+ defaultsTo: false,
+ negatable: false,
+ hide: hide)
+ ..addFlag('sdk-warnings',
+ help: 'Show warnings from SDK imports.',
+ defaultsTo: false,
+ negatable: false,
+ hide: hide)
..addFlag('log',
help: 'Log additional messages and exceptions.',
defaultsTo: false,
« no previous file with comments | « pkg/analyzer_cli/README.md ('k') | pkg/analyzer_cli/test/options_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698