Remove and hide analyzer cli flags.

pkg/analyzer_cli/lib/src/options.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.options;
 
 import 'dart:io';
 
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/src/command_line/arguments.dart';
@@ skipping 154 matching lines @@
         ignoreUnrecognizedFlags = args['ignore-unrecognized-flags'],
         lints = args['lints'],
         log = args['log'],
         machineFormat = args['format'] == 'machine',
         perfReport = args['x-perf-report'],
         shouldBatch = args['batch'],
         showPackageWarnings = args['show-package-warnings'] ||
             args['package-warnings'] ||
             args['x-package-warnings-prefix'] != null,
         showPackageWarningsPrefix = args['x-package-warnings-prefix'],
-        showSdkWarnings = args['show-sdk-warnings'] || args['warnings'],
+        showSdkWarnings = args['sdk-warnings'],
         sourceFiles = args.rest,
         warningsAreFatal = args['fatal-warnings'],
         strongMode = args['strong'],
         implicitCasts = !args['no-implicit-casts'],
         implicitDynamic = !args['no-implicit-dynamic'],
         lintsAreFatal = args['fatal-lints'],
         useAnalysisDriverMemoryByteStore =
             args['use-analysis-driver-memory-byte-store'],
         verbose = args['verbose'];
 
@@ skipping 122 matching lines @@
       ..addFlag('fatal-warnings',
           help: 'Treat non-type warnings as fatal.',
           defaultsTo: false,
           negatable: false)
       ..addFlag('fatal-lints',
           help: 'Treat lints as fatal.', defaultsTo: false, negatable: false)
       ..addFlag('package-warnings',
           help: 'Show warnings from package: imports.',
           defaultsTo: false,
           negatable: false)
-      ..addFlag('show-package-warnings',
-          help: 'Show warnings from package: imports (deprecated).',
-          defaultsTo: false,
-          negatable: false)
-      ..addFlag('warnings',
-          help: 'Show warnings from SDK imports.',
-          defaultsTo: false,
-          negatable: false)
-      ..addFlag('show-sdk-warnings',
-          help: 'Show warnings from SDK imports (deprecated).',
-          defaultsTo: false,
-          negatable: false)
       ..addFlag('help',
           abbr: 'h',
           help:
               'Display this help message. Add --verbose to show hidden options.',
           defaultsTo: false,
           negatable: false)
       ..addFlag('verbose',
           abbr: 'v',
           defaultsTo: false,
           help: 'Verbose output.',
@@ skipping 72 matching lines @@
       ..addOption('x-package-warnings-prefix',
           help:
               'Show warnings from package: imports that match the given prefix',
           hide: hide)
       ..addFlag('enable-conditional-directives',
           help:
               'deprecated -- Enable support for conditional directives (DEP 40).',
           defaultsTo: false,
           negatable: false,
           hide: hide)
+      ..addFlag('show-package-warnings',

[Brian Wilkerson, 2017/02/22 22:01:59]

"remove the deprecated --show-package-warnings" - it doesn't look like it was
removed.

[devoncarew, 2017/02/22 22:07:43]

ack - this should have read "hide --show-package-warnings". I kept it for (some)
consistency with the dart2js flag.

+          help: 'Show warnings from package: imports (deprecated).',
+          defaultsTo: false,
+          negatable: false,
+          hide: hide)
+      ..addFlag('sdk-warnings',
+          help: 'Show warnings from SDK imports.',
+          defaultsTo: false,
+          negatable: false,
+          hide: hide)
       ..addFlag('log',
           help: 'Log additional messages and exceptions.',
           defaultsTo: false,
           negatable: false,
           hide: hide)
       ..addFlag('enable_type_checks',
           help: 'Check types in constant evaluation.',
           defaultsTo: false,
           negatable: false,
           hide: hide)
@@ skipping 84 matching lines @@
         'Usage: $_binaryName [options...] <directory or list of files>');
     errorSink.writeln('');
     errorSink.writeln(parser.usage);
     errorSink.writeln('');
     errorSink.writeln('''
 Run "dartanalyzer -h -v" for verbose help output, including less commonly used options.
 For more information, see http://www.dartlang.org/tools/analyzer.
 ''');
   }
 }