Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2713613003: Revert of DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (Closed)

Created:
3 years, 10 months ago by caseq
Modified:
3 years, 10 months ago
Reviewers:
kozy, dgozman, alph, pfeldman
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, caseq+blink_chromium.org, Peter Beverloo, awdf+watch_chromium.org, pfeldman+blink_chromium.org, mlamouri+watch-blink_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, timvolodine, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (patchset #6 id:100001 of https://codereview.chromium.org/2700293002/ ) Reason for revert: This broke build according to #39 Original issue's description: > DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. > > BUG=693803 > > Review-Url: https://codereview.chromium.org/2700293002 > Cr-Commit-Position: refs/heads/master@{#452355} > Committed: https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa298450c23462 TBR=kozyatinskiy@chromium.org,dgozman@chromium.org,alph@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693803 Review-Url: https://codereview.chromium.org/2713613003 Cr-Commit-Position: refs/heads/master@{#452367} Committed: https://chromium.googlesource.com/chromium/src/+/26664a7d9d2e37eeaaf5f565cb651a4f37c4e438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -124 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-break-program.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp View 3 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 6 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 3 chunks +15 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 4 chunks +20 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 4 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
caseq
Created Revert of DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where ...
3 years, 10 months ago (2017-02-23 03:09:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713613003/1
3 years, 10 months ago (2017-02-23 03:10:05 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:11:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26664a7d9d2e37eeaaf5f565cb65...

Powered by Google App Engine
This is Rietveld 408576698