Chromium Code Reviews
DescriptionRevert of Getting rid of immediate ack in DelegatedFrameHost (patchset #2 id:20001 of https://codereview.chromium.org/2710263002/ )
Reason for revert:
This CL is likely causing CaptureScreenshotTest.CaptureScreenshotArea test failures. See more details at https://bugs.chromium.org/p/chromium/issues/detail?id=695718
BUG=695718
Original issue's description:
> Getting rid of immediate ack in DelegatedFrameHost
>
> When DelegatedFrameHost receives a frame from the renderer that does not
> have the right size, it sends back an ack immediately so that the
> renderer sends a new frame (hopefully with the right size) as soon as
> possible. The problem is that this feature relies on SubmitCompositorFrame
> taking an ack callback which will no longer be true once we switch to
> CompositorFrameSinkSupport. This CL removes the immediate ack feature
> altogether. I tested this change and I could not see a noticable
> difference in resize latency.
>
> BUG=692880
>
> Review-Url: https://codereview.chromium.org/2710263002
> Cr-Commit-Position: refs/heads/master@{#452648}
> Committed: https://chromium.googlesource.com/chromium/src/+/8e0074effadf2beceb5df755b7e61ef095cde7a1
TBR=fsamuel@chromium.org,jbauman@chromium.org,jam@chromium.org,samans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692880
Review-Url: https://codereview.chromium.org/2713553013
Cr-Commit-Position: refs/heads/master@{#452710}
Committed: https://chromium.googlesource.com/chromium/src/+/208c75a57f289ba9e0fc10582179320900ad77e5
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||