Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2713553013: Revert of Getting rid of immediate ack in DelegatedFrameHost (Closed)

Created:
3 years, 10 months ago by lazyboy
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Getting rid of immediate ack in DelegatedFrameHost (patchset #2 id:20001 of https://codereview.chromium.org/2710263002/ ) Reason for revert: This CL is likely causing CaptureScreenshotTest.CaptureScreenshotArea test failures. See more details at https://bugs.chromium.org/p/chromium/issues/detail?id=695718 BUG=695718 Original issue's description: > Getting rid of immediate ack in DelegatedFrameHost > > When DelegatedFrameHost receives a frame from the renderer that does not > have the right size, it sends back an ack immediately so that the > renderer sends a new frame (hopefully with the right size) as soon as > possible. The problem is that this feature relies on SubmitCompositorFrame > taking an ack callback which will no longer be true once we switch to > CompositorFrameSinkSupport. This CL removes the immediate ack feature > altogether. I tested this change and I could not see a noticable > difference in resize latency. > > BUG=692880 > > Review-Url: https://codereview.chromium.org/2710263002 > Cr-Commit-Position: refs/heads/master@{#452648} > Committed: https://chromium.googlesource.com/chromium/src/+/8e0074effadf2beceb5df755b7e61ef095cde7a1 TBR=fsamuel@chromium.org,jbauman@chromium.org,jam@chromium.org,samans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692880 Review-Url: https://codereview.chromium.org/2713553013 Cr-Commit-Position: refs/heads/master@{#452710} Committed: https://chromium.googlesource.com/chromium/src/+/208c75a57f289ba9e0fc10582179320900ad77e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M content/browser/renderer_host/delegated_frame_host.cc View 3 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lazyboy
Created Revert of Getting rid of immediate ack in DelegatedFrameHost
3 years, 10 months ago (2017-02-24 01:41:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713553013/1
3 years, 10 months ago (2017-02-24 01:42:39 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 01:44:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/208c75a57f289ba9e0fc10582179...

Powered by Google App Engine
This is Rietveld 408576698