Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2710263002:
Getting rid of immediate ack in DelegatedFrameHost (Closed)
|
Created:
3 years, 10 months ago by Saman Sami Modified:
3 years, 10 months ago CC:
chromium-reviews, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGetting rid of immediate ack in DelegatedFrameHost
When DelegatedFrameHost receives a frame from the renderer that does not
have the right size, it sends back an ack immediately so that the
renderer sends a new frame (hopefully with the right size) as soon as
possible. The problem is that this feature relies on SubmitCompositorFrame
taking an ack callback which will no longer be true once we switch to
CompositorFrameSinkSupport. This CL removes the immediate ack feature
altogether. I tested this change and I could not see a noticable
difference in resize latency.
BUG=692880
Review-Url: https://codereview.chromium.org/2710263002
Cr-Commit-Position: refs/heads/master@{#452648}
Committed: https://chromium.googlesource.com/chromium/src/+/8e0074effadf2beceb5df755b7e61ef095cde7a1
Patch Set 1 #Patch Set 2 : Remove desired size #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Getting rid of immediate ack in DelegatedFrameHost BUG=692880 ========== to ========== Getting rid of immediate ack in DelegatedFrameHost When DelegatedFrameHost receives a frame from the renderer that does not have the right size, it sends back an ack immediately so that the renderer sends a new frame (hopefully with the right size) as soon as possible. The problem is that this feature relies on SubmitCompositorFrame taking an ack callback which will no longer be true once we switch to CompositorFrameSinkSupport. This CL removes the immediate ack feature altogether. I tested this change and I could not see a noticable difference in resize latency. BUG=692880 ==========
samans@chromium.org changed reviewers: + fsamuel@chromium.org
PTAL
samans@chromium.org changed reviewers: + jbauman@chromium.org
LGTM. Ultimately surface synchronization will replace the current ResizeLock logic but we want to clean up DelegatedFrameHost along the way to make sure we maintain feature and performance parity in Mus, and Mus+Ash.
samans@chromium.org changed reviewers: + jam@chromium.org
jbauman@: Please review DelagatedFrameHost jam@: Please review DelagatedFrameHost
lgtm can you guys add per-file owners for these files so you don't need stamps?
lgtm. I tested resizing webgl aquarium on windows 10 and couldn't see any difference either.
On 2017/02/23 21:54:24, jbauman wrote: > lgtm. I tested resizing webgl aquarium on windows 10 and couldn't see any > difference either. jbauman@: Thanks for testing! jam@: Yes, we'll do that.
The CQ bit was checked by samans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/23 21:59:26, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... jbauman@ and I are now *DelegatedFrame* owners: https://codereview.chromium.org/2710593007/
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487887113627890,
"parent_rev": "2f8faeaffdf9e93caaf0dab7e99d733e3d6278d3", "commit_rev":
"8e0074effadf2beceb5df755b7e61ef095cde7a1"}
Message was sent while issue was closed.
Description was changed from ========== Getting rid of immediate ack in DelegatedFrameHost When DelegatedFrameHost receives a frame from the renderer that does not have the right size, it sends back an ack immediately so that the renderer sends a new frame (hopefully with the right size) as soon as possible. The problem is that this feature relies on SubmitCompositorFrame taking an ack callback which will no longer be true once we switch to CompositorFrameSinkSupport. This CL removes the immediate ack feature altogether. I tested this change and I could not see a noticable difference in resize latency. BUG=692880 ========== to ========== Getting rid of immediate ack in DelegatedFrameHost When DelegatedFrameHost receives a frame from the renderer that does not have the right size, it sends back an ack immediately so that the renderer sends a new frame (hopefully with the right size) as soon as possible. The problem is that this feature relies on SubmitCompositorFrame taking an ack callback which will no longer be true once we switch to CompositorFrameSinkSupport. This CL removes the immediate ack feature altogether. I tested this change and I could not see a noticable difference in resize latency. BUG=692880 Review-Url: https://codereview.chromium.org/2710263002 Cr-Commit-Position: refs/heads/master@{#452648} Committed: https://chromium.googlesource.com/chromium/src/+/8e0074effadf2beceb5df755b7e6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8e0074effadf2beceb5df755b7e6...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2713553013/ by lazyboy@chromium.org. The reason for reverting is: This CL is likely causing CaptureScreenshotTest.CaptureScreenshotArea test failures. See more details at https://bugs.chromium.org/p/chromium/issues/detail?id=695718 BUG=695718. |
