Chromium Code Reviews
DescriptionMerge 2987: Fix hyphenated words not to overflow on Android
This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.
The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.
The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
but the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.
BUG=692094
Review-Url: https://codereview.chromium.org/2692233005
Cr-Commit-Position: refs/heads/master@{#451519}
(cherry picked from commit dd1e6431c28b8f3de55d580b66662859baf9d28b)
Review-Url: https://codereview.chromium.org/2713553007 .
Cr-Commit-Position: refs/branch-heads/2987@{#659}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/d9397e81ac507fdd66d1eb316dae364e3cfbcffe
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||