Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2713553007: Merge 2987: Fix hyphenated words not to overflow on Android (Closed)

Created:
3 years, 10 months ago by kojii
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge 2987: Fix hyphenated words not to overflow on Android This patch fixes to choose the correct hyphenation point when the word has multiple hyphenation points on Android. The line breaker computes the number of characters that can fit and computes that last hyphenation point within the number. The number was not used correctly in the Android hyphenation engine. The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|, but the test isn't small. The hyphenation engine loads dictionaries using a mojo service, but since the mojo service is not available in unit tests, the test creates the engine from the dictionary file it loaded. BUG=692094 Review-Url: https://codereview.chromium.org/2692233005 Cr-Commit-Position: refs/heads/master@{#451519} (cherry picked from commit dd1e6431c28b8f3de55d580b66662859baf9d28b) Review-Url: https://codereview.chromium.org/2713553007 . Cr-Commit-Position: refs/branch-heads/2987@{#659} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d9397e81ac507fdd66d1eb316dae364e3cfbcffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -27 lines) Patch
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/HyphenationTest.cpp View 2 chunks +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.h View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp View 5 chunks +21 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
3 years, 10 months ago (2017-02-23 14:24:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9397e81ac507fdd66d1eb316dae364e3cfbcffe.

Powered by Google App Engine
This is Rietveld 408576698