Fix hyphenated words not to overflow on Android

Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
but the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094
Review-Url: https://codereview.chromium.org/2692233005
Cr-Commit-Position: refs/heads/master@{#451519}
Committed: https://chromium.googlesource.com/chromium/src/+/dd1e6431c28b8f3de55d580b66662859baf9d28b

[kojii, 2017-02-15 07:53:31]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 07:53:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-15 10:28:04]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 10:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-15 10:32:09]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-02-15 10:46:57]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-02-15 10:47:07]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-15 10:47:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 12:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 12:23:47]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-02-15 18:25:52]

Description was changed from

==========
WIP: hyphen-test

BUG=

patch from issue 2699493003 at patchset 1 (http://crrev.com/2699493003#ps1)
==========

to

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
and the rests are test code. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loads.

BUG=692094
==========

[kojii, 2017-02-16 02:13:27]

Description was changed from

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
and the rests are test code. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loads.

BUG=692094
==========

to

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
and the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094
==========

[kojii, 2017-02-16 02:14:24]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-02-16 02:14:25]

PTAL. Apologies, I should have tests for the interface layer from the beginning.

[kojii, 2017-02-16 02:42:09]

Removed "WIP:", forgot doing so before publish.

[eae, 2017-02-17 19:00:09]

LGTM

[kojii, 2017-02-18 03:51:52]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:52:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-18 03:52:29]

Description was changed from

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
and the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094
==========

to

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
but the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094
==========

[commit-bot: I haz the power, 2017-02-18 05:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 05:53:24]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[kojii, 2017-02-18 08:48:41]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-18 08:48:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 10:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 10:23:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-02-19 04:40:37]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-19 04:40:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 09:11:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487479237798320,
"parent_rev": "b218ccd8ae08ba89f2038c10a2aa746dff8a424d", "commit_rev":
"dd1e6431c28b8f3de55d580b66662859baf9d28b"}

[commit-bot: I haz the power, 2017-02-19 09:12:01]

Description was changed from

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
but the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094
==========

to

==========
Fix hyphenated words not to overflow on Android

This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
but the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094

Review-Url: https://codereview.chromium.org/2692233005
Cr-Commit-Position: refs/heads/master@{#451519}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd1e6431c28b8f3de55d580b6666...
==========

[commit-bot: I haz the power, 2017-02-19 09:12:03]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dd1e6431c28b8f3de55d580b6666...