Add GL_EXT_color_buffer_half_float support

Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2713553005
Cr-Commit-Position: refs/heads/master@{#452909}
Committed: https://chromium.googlesource.com/chromium/src/+/8507215795207d4868c9ad379957819c2f15b881

[ccameron, 2017-02-22 23:58:43]

Description was changed from

==========
Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
==========

to

==========
Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-02-22 23:58:44]

Description was changed from

==========
Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-02-22 23:58:45]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2017-02-22 23:59:29]

ccameron@chromium.org changed reviewers:
+ zmo@chromium.org

[ccameron, 2017-02-22 23:59:29]

ptal

[commit-bot: I haz the power, 2017-02-22 23:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-02-23 00:36:57]

Mostly looks good with a small request to get it also for WebGL1.

https://codereview.chromium.org/2713553005/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2713553005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:870: if (context_type_ ==
CONTEXT_TYPE_OPENGLES2 &&
or WebGL1

Since you are working on it for internal ES2, it's only a little extra bits to
get it right for WebGL1

https://codereview.chromium.org/2713553005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:918: EnableEXTColorBufferHalfFloat();
You can't enable this by default on WebGL contexts.  Look at
ContextGroup::Initialize(), where you should set disallowed_features_ and only
enable it conditionally like other texture extensions.

[ccameron, 2017-02-23 02:08:35]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 02:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-02-23 02:11:57]

Updated

https://codereview.chromium.org/2713553005/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2713553005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:870: if (context_type_ ==
CONTEXT_TYPE_OPENGLES2 &&
On 2017/02/23 00:36:57, Zhenyao Mo wrote:
> or WebGL1
> 
> Since you are working on it for internal ES2, it's only a little extra bits to
> get it right for WebGL1

Done.

https://codereview.chromium.org/2713553005/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:918: EnableEXTColorBufferHalfFloat();
On 2017/02/23 00:36:57, Zhenyao Mo wrote:
> You can't enable this by default on WebGL contexts.  Look at
> ContextGroup::Initialize(), where you should set disallowed_features_ and only
> enable it conditionally like other texture extensions.

Disallowed for WebGL 2.

[commit-bot: I haz the power, 2017-02-23 05:00:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 05:00:44]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2017-02-23 05:49:10]

LGTM with one nit fixed

https://codereview.chromium.org/2713553005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_group.cc (right):

https://codereview.chromium.org/2713553005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_group.cc:56:
adjusted_disallowed_features.ext_color_buffer_half_float = true;
This also needs to be disallowed for WebGL1 because the extension has to be
explicitly enabled later.

[ccameron, 2017-02-23 07:07:54]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 07:08:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 10:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 10:03:31]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[ccameron, 2017-02-24 00:48:09]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:49:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 01:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:08:52]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[ccameron, 2017-02-24 02:10:51]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:11:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-02-24 02:13:11]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:13:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 03:37:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:37:36]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-02-24 04:53:44]

ccameron@chromium.org changed reviewers:
+ tsepez@chromium.org

[ccameron, 2017-02-24 04:53:44]

Adding tsepez@ for ipc

[Tom Sepez, 2017-02-24 16:59:47]

ipc lgtm

[ccameron, 2017-02-24 19:44:43]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-02-24 19:44:43]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2713553005/#ps120001
(title: "Fix compile error")

[commit-bot: I haz the power, 2017-02-24 19:45:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:53:27]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487965483105010,
"parent_rev": "37f56cc44a7c70fac06f84ab97fb2473d872bffd", "commit_rev":
"8507215795207d4868c9ad379957819c2f15b881"}

[commit-bot: I haz the power, 2017-02-24 19:54:02]

Description was changed from

==========
Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add GL_EXT_color_buffer_half_float support

Only expose for GLES2 contexts.

For desktop support, add simliar checks to GL_EXT_color_buffer_float.

Change a number of instances of accidentally referring to the extension
as "color_buffer_float" instead of "color_buffer_half_float".

BUG=687439
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2713553005
Cr-Commit-Position: refs/heads/master@{#452909}
Committed:
https://chromium.googlesource.com/chromium/src/+/8507215795207d4868c9ad379957...
==========

[commit-bot: I haz the power, 2017-02-24 19:54:03]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8507215795207d4868c9ad379957...