Refactor task enqueuing

Refactor task enqueuing

BUG=692433
Review-Url: https://codereview.chromium.org/2713533002
Committed: https://github.com/luci/luci-py/commit/51abdc79bf08bf66f5cb87e9e4d3c40188b4c792

[smut, 2017-02-22 00:32:12]

Patchset #1 (id:1) has been deleted

[smut, 2017-02-22 00:33:46]

Description was changed from

==========
Monitor task enqueuing attempts

BUG=692433
==========

to

==========
Monitor task enqueuing attempts

Report successes and failures in enqueuing tasks.

BUG=692433
==========

[smut, 2017-02-22 00:34:02]

smut@google.com changed reviewers:
+ sergeyberezin@chromium.org

[Sergey Berezin, 2017-02-22 01:35:51]

Code LGTM, and refactoring is also great. I'm not sure about usefulness of
monitoring successes of taskqueues though - it's probably too low level. IMHO
it's more interesting to monitor the result of performing a task (and maybe we
already do?), since that's service-specific.

[smut, 2017-02-22 02:36:57]

On 2017/02/22 01:35:51, Sergey Berezin wrote:
> Code LGTM, and refactoring is also great. I'm not sure about usefulness of
> monitoring successes of taskqueues though - it's probably too low level. IMHO
> it's more interesting to monitor the result of performing a task (and maybe we
> already do?), since that's service-specific.

Hm, yeah I'm not sure what is actually needed here.

[smut, 2017-02-23 02:09:33]

Description was changed from

==========
Monitor task enqueuing attempts

Report successes and failures in enqueuing tasks.

BUG=692433
==========

to

==========
Refactor task enqueuing

BUG=692433
==========

[smut, 2017-02-23 02:09:48]

Removed the useless metric, rewrote the description.

[smut, 2017-02-23 02:09:53]

The CQ bit was checked by smut@google.com

[smut, 2017-02-23 02:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://codereview.chromium.org/2713533002/#ps40001
(title: "Remove metric")

[commit-bot: I haz the power, 2017-02-23 02:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[smut, 2017-02-23 02:10:08]

The CQ bit was unchecked by smut@google.com

[smut, 2017-02-23 02:10:36]

Patchset #2 (id:40001) has been deleted

[smut, 2017-02-23 02:10:39]

The CQ bit was checked by smut@google.com

[smut, 2017-02-23 02:10:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://codereview.chromium.org/2713533002/#ps60001
(title: "Remove metric")

[commit-bot: I haz the power, 2017-02-23 02:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 02:13:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487815839363880,
"parent_rev": "37a1ef32412c606c26a535551acb2aa4fa25cd8b", "commit_rev":
"51abdc79bf08bf66f5cb87e9e4d3c40188b4c792"}

[commit-bot: I haz the power, 2017-02-23 02:13:10]

Description was changed from

==========
Refactor task enqueuing

BUG=692433
==========

to

==========
Refactor task enqueuing

BUG=692433

Review-Url: https://codereview.chromium.org/2713533002
Committed:
https://github.com/luci/luci-py/commit/51abdc79bf08bf66f5cb87e9e4d3c40188b4c792
==========

[commit-bot: I haz the power, 2017-02-23 02:13:11]

Committed patchset #2 (id:60001) as
https://github.com/luci/luci-py/commit/51abdc79bf08bf66f5cb87e9e4d3c40188b4c792