Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: appengine/gce-backend/instance_templates.py

Issue 2713533002: Refactor task enqueuing (Closed)
Patch Set: Remove metric Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/gce-backend/instance_templates.py
diff --git a/appengine/gce-backend/instance_templates.py b/appengine/gce-backend/instance_templates.py
index 62d092f3a9e3938af17d6f7da2143c99973e6f35..adf9cdb0f251c2988a115a29dfe86476efd45c4e 100644
--- a/appengine/gce-backend/instance_templates.py
+++ b/appengine/gce-backend/instance_templates.py
@@ -10,9 +10,9 @@ from google.appengine.ext import ndb
from components import gce
from components import net
-from components import utils
import models
+import utilities
def get_instance_template_key(base_name):
@@ -163,17 +163,8 @@ def schedule_creation():
if instance_template.active:
instance_template_revision = instance_template.active.get()
if instance_template_revision and not instance_template_revision.url:
- if not utils.enqueue_task(
- '/internal/queues/create-instance-template',
- 'create-instance-template',
- params={
- 'key': instance_template.active.urlsafe(),
- },
- ):
- logging.warning(
- 'Failed to enqueue task for InstanceTemplateRevision: %s',
- instance_template.active,
- )
+ utilities.enqueue_task(
+ 'create-instance-template', instance_template.active)
def get_instance_template_to_delete(key):
@@ -257,12 +248,4 @@ def schedule_deletion():
instance_template = key.get()
if instance_template and instance_template.url:
if not instance_template.active and not instance_template.drained:
- if not utils.enqueue_task(
- '/internal/queues/delete-instance-template',
- 'delete-instance-template',
- params={
- 'key': key.urlsafe(),
- },
- ):
- logging.warning(
- 'Failed to enqueue task for InstanceTemplateRevision: %s', key)
+ utilities.enqueue_task('delete-instance-template', key)
« no previous file with comments | « appengine/gce-backend/instance_group_managers_test.py ('k') | appengine/gce-backend/instance_templates_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698