Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2713453002: Revert of Correctly compute parent of AXMenuListOption (Closed)

Created:
3 years, 10 months ago by amineer
Modified:
3 years, 10 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Correctly compute parent of AXMenuListOption (patchset #8 id:160001 of https://codereview.chromium.org/2670023002/ ) Reason for revert: Causing crashes BUG=687835, 694349 Original issue's description: > Correctly compute parent of AXMenuListOption > > BUG=687835 > > Review-Url: https://codereview.chromium.org/2670023002 > Cr-Commit-Position: refs/heads/master@{#451530} > Committed: https://chromium.googlesource.com/chromium/src/+/dbc08d987df8d944144250b50c6cffc044d517c1 TBR=dmazzoni@chromium.org,aboxhall@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=687835 Review-Url: https://codereview.chromium.org/2713453002 Cr-Commit-Position: refs/heads/master@{#451865} Committed: https://chromium.googlesource.com/chromium/src/+/8dd7ebcfe2458163d1faa4d0de517affec380d90

Patch Set 1 #

Messages

Total messages: 17 (7 generated)
amineer
Created Revert of Correctly compute parent of AXMenuListOption
3 years, 10 months ago (2017-02-21 19:33:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713453002/1
3 years, 10 months ago (2017-02-21 19:35:00 UTC) #3
aboxhall
On 2017/02/21 19:35:00, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-21 21:28:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
3 years, 10 months ago (2017-02-21 21:39:31 UTC) #6
amineer
On 2017/02/21 21:28:25, aboxhall wrote: > On 2017/02/21 19:35:00, commit-bot: I haz the power wrote: ...
3 years, 10 months ago (2017-02-21 22:11:43 UTC) #7
aboxhall
On 2017/02/21 22:11:43, amineer wrote: > On 2017/02/21 21:28:25, aboxhall wrote: > > On 2017/02/21 ...
3 years, 10 months ago (2017-02-21 22:15:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713453002/1
3 years, 10 months ago (2017-02-21 22:21:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-22 00:25:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713453002/1
3 years, 10 months ago (2017-02-22 00:31:43 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:16:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8dd7ebcfe2458163d1faa4d0de51...

Powered by Google App Engine
This is Rietveld 408576698