Correctly compute parent of AXMenuListOption

Correctly compute parent of AXMenuListOption

BUG=687835
Review-Url: https://codereview.chromium.org/2670023002
Cr-Commit-Position: refs/heads/master@{#451530}
Committed: https://chromium.googlesource.com/chromium/src/+/dbc08d987df8d944144250b50c6cffc044d517c1

[aboxhall, 2017-02-02 03:12:14]

aboxhall@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[aboxhall, 2017-02-02 03:12:15]

In certain circumstances, populateChildren had not yet been called on the owning
AXMenuListPopup object, meaning the AXMenuListOption object had no parent set.

[dmazzoni, 2017-02-02 04:47:45]

lgtm

Maybe file a bug for this one indicating how you ran across this - in the wild?
in a layout test?

[aboxhall, 2017-02-02 05:50:22]

Description was changed from

==========
Correctly compute parent of AXMenuListOption

BUG=
==========

to

==========
Correctly compute parent of AXMenuListOption

BUG=687835
==========

[aboxhall, 2017-02-02 05:50:32]

On 2017/02/02 04:47:45, dmazzoni wrote:
> lgtm
> 
> Maybe file a bug for this one indicating how you ran across this - in the
wild?
> in a layout test?

Done, and added a layout test.

[aboxhall, 2017-02-02 06:07:19]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 06:07:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 06:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 06:25:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[aboxhall, 2017-02-02 06:35:05]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 06:35:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 06:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 06:44:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aboxhall, 2017-02-03 03:59:10]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 04:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 05:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:54:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aboxhall, 2017-02-08 02:10:01]

Patchset #6 (id:100001) has been deleted

[aboxhall, 2017-02-10 05:24:56]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 05:25:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 07:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:37:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aboxhall, 2017-02-15 00:22:24]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 00:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 02:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 02:14:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[aboxhall, 2017-02-16 01:32:09]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 01:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:37:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[aboxhall, 2017-02-16 06:37:36]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 06:38:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 07:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 07:47:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aboxhall, 2017-02-17 02:37:07]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 02:38:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:04:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[aboxhall, 2017-02-19 22:19:25]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2017-02-19 22:19:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2670023002/#ps160001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-02-19 22:19:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 23:33:11]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487542765428440,
"parent_rev": "da4abde4e18f7453c6fe591ad27fca4112a67b7f", "commit_rev":
"dbc08d987df8d944144250b50c6cffc044d517c1"}

[commit-bot: I haz the power, 2017-02-19 23:33:43]

Description was changed from

==========
Correctly compute parent of AXMenuListOption

BUG=687835
==========

to

==========
Correctly compute parent of AXMenuListOption

BUG=687835

Review-Url: https://codereview.chromium.org/2670023002
Cr-Commit-Position: refs/heads/master@{#451530}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbc08d987df8d944144250b50c6c...
==========

[commit-bot: I haz the power, 2017-02-19 23:33:44]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/dbc08d987df8d944144250b50c6c...

[amineer, 2017-02-21 19:33:02]

A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/2713453002/ by amineer@chromium.org.

The reason for reverting is: Causing crashes

BUG=687835,694349.