Turn on the flag for 'allow-top-navigation-by-user-activation'.

Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to "stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/El0ueyoNgRE

BUG=662506
Review-Url: https://codereview.chromium.org/2713283002
Cr-Commit-Position: refs/heads/master@{#453327}
Committed: https://chromium.googlesource.com/chromium/src/+/edeee45ff630ec55e37944197900c3b5846631c7

[Bin Lu, 2017-02-24 20:32:10]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[Bin Lu, 2017-02-24 20:33:18]

Description was changed from

==========
Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to
"stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

BUG=
==========

to

==========
Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to
"stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/El0ueyoNgRE

BUG=
==========

[Bin Lu, 2017-02-24 20:33:19]

binlu@google.com changed reviewers:
+ domenic@chromium.org, ojan@chromium.org, rbyers@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:33:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rick Byers, 2017-02-24 20:40:39]

LGTM but please wait for the 3 LGTMs on the intent-to-ship thread before
landing.

[Bin Lu, 2017-02-24 20:54:28]

Description was changed from

==========
Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to
"stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/El0ueyoNgRE

BUG=
==========

to

==========
Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to
"stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/El0ueyoNgRE

BUG=662506
==========

[commit-bot: I haz the power, 2017-02-24 22:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:58:05]

Dry run: This issue passed the CQ dry run.

[Bin Lu, 2017-02-27 13:45:47]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 13:45:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-02-27 13:49:30]

Thanks Rick for the quick review! 

I made a small change to the error message for blocked navigation inside
sandboxed iframes.
Does it look good? Thanks.

On 2017/02/24 20:40:39, Rick Byers wrote:
> LGTM but please wait for the 3 LGTMs on the intent-to-ship thread before
> landing.

[commit-bot: I haz the power, 2017-02-27 15:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 15:21:58]

Dry run: This issue passed the CQ dry run.

[Bin Lu, 2017-02-27 17:54:00]

On 2017/02/27 13:49:30, Bin Lu wrote:
> Thanks Rick for the quick review! 
> 
> I made a small change to the error message for blocked navigation inside
> sandboxed iframes.
> Does it look good? Thanks.
> 
BTW: Do I also need to add the flag to places like
chrome/browser/about_flags.cc, content/public/common/content_features.h, etc?
Like what https://codereview.chromium.org/2092293002/ did for disabling
Framebust?
Currently, it's not: It seems the status of "experimental" didn't turn it on for
non-stable Chrome, and I'd like to make sure marking it as 'stable' would make
it work everywhere.

Thanks!

[ojan, 2017-02-27 17:56:55]

On 2017/02/27 at 17:54:00, binlu wrote:
> On 2017/02/27 13:49:30, Bin Lu wrote:
> > Thanks Rick for the quick review! 
> > 
> > I made a small change to the error message for blocked navigation inside
> > sandboxed iframes.
> > Does it look good? Thanks.
> > 
> BTW: Do I also need to add the flag to places like
chrome/browser/about_flags.cc, content/public/common/content_features.h, etc?
> Like what https://codereview.chromium.org/2092293002/ did for disabling
Framebust?
> Currently, it's not: It seems the status of "experimental" didn't turn it on
for non-stable Chrome, and I'd like to make sure marking it as 'stable' would
make it work everywhere.

Marking it as stable is the right thing to do. You only need to do the other
flag bits if you have an entry in about:flags that you need users to be able to
turn on/off for testing. In this case, the change is very safe and we don't need
experimentation from users to find problem cases, so just the
RuntimeEnabledFeatures.json5 change is enough.

> 
> Thanks!

[Bin Lu, 2017-02-27 20:45:36]

Thanks Ojan! Submitting now.

On 2017/02/27 17:56:55, ojan wrote:
> On 2017/02/27 at 17:54:00, binlu wrote:
> > On 2017/02/27 13:49:30, Bin Lu wrote:
> > > Thanks Rick for the quick review! 
> > > 
> > > I made a small change to the error message for blocked navigation inside
> > > sandboxed iframes.
> > > Does it look good? Thanks.
> > > 
> > BTW: Do I also need to add the flag to places like
> chrome/browser/about_flags.cc, content/public/common/content_features.h, etc?
> > Like what https://codereview.chromium.org/2092293002/ did for disabling
> Framebust?
> > Currently, it's not: It seems the status of "experimental" didn't turn it on
> for non-stable Chrome, and I'd like to make sure marking it as 'stable' would
> make it work everywhere.
> 
> Marking it as stable is the right thing to do. You only need to do the other
> flag bits if you have an entry in about:flags that you need users to be able
to
> turn on/off for testing. In this case, the change is very safe and we don't
need
> experimentation from users to find problem cases, so just the
> RuntimeEnabledFeatures.json5 change is enough.
> 
> > 
> > Thanks!

[Bin Lu, 2017-02-27 20:45:47]

The CQ bit was checked by binlu@google.com

[Bin Lu, 2017-02-27 20:45:48]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2713283002/#ps20001
(title: "Refine the error message for blocked navigation within sandboxed
iframe.")

[commit-bot: I haz the power, 2017-02-27 20:46:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:50:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488228347957650,
"parent_rev": "09fc5ab0671709f4c32fcbab09bbe76f8b969188", "commit_rev":
"edeee45ff630ec55e37944197900c3b5846631c7"}

[commit-bot: I haz the power, 2017-02-27 20:51:26]

Description was changed from

==========
Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to
"stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/El0ueyoNgRE

BUG=662506
==========

to

==========
Turn on the flag for 'allow-top-navigation-by-user-activation'.

Change the feature of TopNavByUserActivationInSandbox from "experimental" to
"stable".
Refine the words in the WPT test for 'allow-top-navigation-by-user-activation'.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/El0ueyoNgRE

BUG=662506

Review-Url: https://codereview.chromium.org/2713283002
Cr-Commit-Position: refs/heads/master@{#453327}
Committed:
https://chromium.googlesource.com/chromium/src/+/edeee45ff630ec55e37944197900...
==========

[commit-bot: I haz the power, 2017-02-27 20:51:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/edeee45ff630ec55e37944197900...