third_party/WebKit/Source/core/frame/Frame.cpp - Issue 2713283002: Turn on the flag for 'allow-top-navigation-by-user-activation'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.cpp

Issue 2713283002: Turn on the flag for 'allow-top-navigation-by-user-activation'. (Closed)

Patch Set: Refine the error message for blocked navigation within sandboxed iframe. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Frame.cpp

diff --git a/third_party/WebKit/Source/core/frame/Frame.cpp b/third_party/WebKit/Source/core/frame/Frame.cpp

index dd7e0fe5d0b4500012adc2eb8da6250bf0d5092b..4b1277762841a8e6c20272a23a96bcb261d2a631 100644

--- a/third_party/WebKit/Source/core/frame/Frame.cpp

+++ b/third_party/WebKit/Source/core/frame/Frame.cpp

@@ -289,11 +289,10 @@ bool Frame::canNavigateWithoutFramebusting(const Frame& targetFrame,

if (securityContext()->isSandboxed(SandboxTopNavigation) &&

securityContext()->isSandboxed(

SandboxTopNavigationByUserActivation)) {

- // TODO(binlu): To add "or 'allow-top-navigation-by-user-activation'"

- // to the reason below, once the new flag is shipped.

reason =

"The frame attempting navigation of the top-level window is "

- "sandboxed, but the 'allow-top-navigation' flag is not set.";

+ "sandboxed, but the flag of 'allow-top-navigation' or "

+ "'allow-top-navigation-by-user-activation' is not set.";

return false;

}

if (securityContext()->isSandboxed(SandboxTopNavigation) &&