Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2713243004: MD Settings: give Chrome logo an alt text (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: give Chrome logo an alt text R=dpapad@chromium.org BUG=693386 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2713243004 Cr-Commit-Position: refs/heads/master@{#453062} Committed: https://chromium.googlesource.com/chromium/src/+/6761779daf843b5afefd405fc3761e961d04313c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/app/chromium_strings.grd View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
3 years, 10 months ago (2017-02-25 02:49:31 UTC) #2
dpapad
lgtm
3 years, 10 months ago (2017-02-25 03:00:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713243004/1
3 years, 10 months ago (2017-02-25 03:09:27 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 04:10:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6761779daf843b5afefd405fc376...

Powered by Google App Engine
This is Rietveld 408576698