Don't dismiss Settings when another view controller is presented on top

Don't dismiss Settings when another view controller is presented on top

This fixes the crash in http://crbug.com/694232.

BUG=694232
R=gambard@chromium.org

Review-Url: https://codereview.chromium.org/2713173002
Cr-Commit-Position: refs/heads/master@{#453587}
Committed: https://chromium.googlesource.com/chromium/src/+/273810c9b85e5c759370dc521dbb1fcccde3500e

[lpromero, 2017-02-24 12:31:29]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 12:31:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-02-24 12:33:29]

https://codereview.chromium.org/2713173002/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_navigation_controller.mm (right):

https://codereview.chromium.org/2713173002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_navigation_controller.mm:545: if ([self
presentedViewController]) {
Are you sure this is reset to nil when the presented view controller is
dismissed?
Maybe we should add an EG test?

[commit-bot: I haz the power, 2017-02-24 13:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 13:02:20]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-02-27 16:55:52]

https://codereview.chromium.org/2713173002/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_navigation_controller.mm (right):

https://codereview.chromium.org/2713173002/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_navigation_controller.mm:545: if ([self
presentedViewController]) {
On 2017/02/24 12:33:28, gambard wrote:
> Are you sure this is reset to nil when the presented view controller is
> dismissed?
> Maybe we should add an EG test?

Done. (Yes the property is correctly updated.)

[lpromero, 2017-02-27 16:56:19]

lpromero@chromium.org changed reviewers:
+ msarda@chromium.org

[lpromero, 2017-02-27 16:56:19]

msarda@chromium.org: Please review changes in
ios/public/provider/chrome/browser/signin.

[msarda, 2017-02-27 17:11:57]

lgtm

[lpromero, 2017-02-27 17:13:21]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:14:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:22:18]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lpromero, 2017-02-27 17:55:17]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-02-27 17:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2713173002/#ps40001
(title: "Fix deps")

[commit-bot: I haz the power, 2017-02-27 17:55:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:04:54]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lpromero, 2017-02-28 12:11:46]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 12:11:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-02-28 12:12:54]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[lpromero, 2017-02-28 12:13:00]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-02-28 12:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2713173002/#ps80001
(title: "Format gn file")

[commit-bot: I haz the power, 2017-02-28 12:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 13:35:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488283980375100,
"parent_rev": "9b5475a957ae0a103d0c93e53355ad7c0d60cb31", "commit_rev":
"273810c9b85e5c759370dc521dbb1fcccde3500e"}

[commit-bot: I haz the power, 2017-02-28 13:36:08]

Description was changed from

==========
Don't dismiss Settings when another view controller is presented on top

This fixes the crash in http://crbug.com/694232.

BUG=694232
R=gambard@chromium.org
==========

to

==========
Don't dismiss Settings when another view controller is presented on top

This fixes the crash in http://crbug.com/694232.

BUG=694232
R=gambard@chromium.org

Review-Url: https://codereview.chromium.org/2713173002
Cr-Commit-Position: refs/heads/master@{#453587}
Committed:
https://chromium.googlesource.com/chromium/src/+/273810c9b85e5c759370dc521dbb...
==========

[commit-bot: I haz the power, 2017-02-28 13:36:09]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/273810c9b85e5c759370dc521dbb...