ios/chrome/browser/ui/settings/settings_navigation_controller.mm - Issue 2713173002: Don't dismiss Settings when another view controller is presented on top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/settings_navigation_controller.mm

Issue 2713173002: Don't dismiss Settings when another view controller is presented on top (Closed)

Patch Set: Format gn file Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/settings/settings_navigation_controller.mm

diff --git a/ios/chrome/browser/ui/settings/settings_navigation_controller.mm b/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

index b1b25e508dcf0a11631a3e674e27d17e7a4e78c3..035118eae4e36ea24f3b26d5bfbb960d399a6520 100644

--- a/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

+++ b/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

@@ -542,6 +542,9 @@ initWithRootViewController:(UIViewController*)rootViewController

#pragma mark - UIResponder

- (NSArray*)keyCommands {

+ if ([self presentedViewController]) {

+ return nil;

+ }

base::WeakNSObject<SettingsNavigationController> weakSelf(self);

return @[

[UIKeyCommand cr_keyCommandWithInput:UIKeyInputEscape