Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2712933002: Revert of Remove CRWSessionEntry usage from BrowserViewController. (Closed)

Created:
3 years, 9 months ago by lody
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove CRWSessionEntry usage from BrowserViewController. (patchset #2 id:20001 of https://codereview.chromium.org/2690943006/ ) Reason for revert: Tests VisibleURLTestCase.testHistoryNavigation and FormsTestCase.testRepostFormAfterIndexNavigation are broken ( see https://bugs.chromium.org/p/chromium/issues/detail?id=695413 ) by issue 2693013005 which requires reverting this change to revert. Original issue's description: > Remove CRWSessionEntry usage from BrowserViewController. > > This CL also removes |-currentSessionEntry| from > PreloadControllerDelegate, as it is unused. > > BUG=454984, 546348 > > Review-Url: https://codereview.chromium.org/2690943006 > Cr-Commit-Position: refs/heads/master@{#452254} > Committed: https://chromium.googlesource.com/chromium/src/+/8793cf8e2e26093c0e38af20be24864c0d1a3cff TBR=eugenebut@chromium.org,kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454984, 546348 Review-Url: https://codereview.chromium.org/2712933002 Cr-Commit-Position: refs/heads/master@{#452477} Committed: https://chromium.googlesource.com/chromium/src/+/d9c3bfd4d75d1022de802c8d620581913f62e5b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M ios/chrome/browser/ui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 3 chunks +12 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/preload_controller_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lody
Created Revert of Remove CRWSessionEntry usage from BrowserViewController.
3 years, 9 months ago (2017-02-23 12:21:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712933002/1
3 years, 9 months ago (2017-02-23 12:21:56 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-02-23 12:21:58 UTC) #5
sdefresne
lgtm
3 years, 9 months ago (2017-02-23 13:46:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712933002/1
3 years, 9 months ago (2017-02-23 13:47:25 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-23 13:48:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9c3bfd4d75d1022de802c8d6205...

Powered by Google App Engine
This is Rietveld 408576698