Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2690943006: Remove CRWSessionEntry usage from BrowserViewController. (Closed)

Created:
3 years, 10 months ago by kkhorimoto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CRWSessionEntry usage from BrowserViewController. This CL also removes |-currentSessionEntry| from PreloadControllerDelegate, as it is unused. BUG=454984, 546348 Review-Url: https://codereview.chromium.org/2690943006 Cr-Commit-Position: refs/heads/master@{#452254} Committed: https://chromium.googlesource.com/chromium/src/+/8793cf8e2e26093c0e38af20be24864c0d1a3cff

Patch Set 1 #

Patch Set 2 : fix DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M ios/chrome/browser/ui/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 3 chunks +3 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/preload_controller_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
kkhorimoto
3 years, 10 months ago (2017-02-15 00:09:54 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-15 01:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690943006/20001
3 years, 10 months ago (2017-02-22 22:42:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8793cf8e2e26093c0e38af20be24864c0d1a3cff
3 years, 10 months ago (2017-02-22 22:59:48 UTC) #12
lody
3 years, 10 months ago (2017-02-23 12:21:43 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2712933002/ by lod@chromium.org.

The reason for reverting is: Tests VisibleURLTestCase.testHistoryNavigation and
FormsTestCase.testRepostFormAfterIndexNavigation are broken ( see
https://bugs.chromium.org/p/chromium/issues/detail?id=695413 ) by issue
2693013005 which requires reverting this change to revert..

Powered by Google App Engine
This is Rietveld 408576698