Closure compiler: fix incremental builds

Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2712893002
Cr-Commit-Position: refs/heads/master@{#452389}
Committed: https://chromium.googlesource.com/chromium/src/+/ec5f9b7821faea7d2083376a934e306e0763572e

[Dan Beam, 2017-02-23 03:13:01]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2017-02-23 03:15:26]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-02-23 03:15:27]

lgtm

[Dan Beam, 2017-02-23 03:18:12]

Description was changed from

==========
Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none
==========

to

==========
Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none
==========

[Dan Beam, 2017-02-23 03:18:12]

dbeam@chromium.org changed reviewers:
- dpapad@chromium.org

[Dan Beam, 2017-02-23 03:18:53]

publishing just so folks see the full description (and can effectively shame me)

[Dan Beam, 2017-02-23 03:19:00]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 03:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 03:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:30:53]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-02-23 04:01:46]

Description was changed from

==========
Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none
==========

to

==========
Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-02-23 04:01:55]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-23 04:02:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 04:20:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487822515160240,
"parent_rev": "21e0e489169ec98a36540905cf7c78ba907b7910", "commit_rev":
"ec5f9b7821faea7d2083376a934e306e0763572e"}

[commit-bot: I haz the power, 2017-02-23 04:21:28]

Description was changed from

==========
Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Closure compiler: fix incremental builds

I added --checks_only to the closure_flags in this CL:
https://codereview.chromium.org/2629323002

Unfortunately, I didn't know that --checks_only appears to not write a
--js_output_file even if specified. This makes sense, as the only
possibly sane thing to write might be an empty file (but that's really
not useful outside of the context of a build system, and would probably
just accidentally nuke people's files).

This CL creates an empty file at the desired location if --checks_only
is on and the compile succeeds. This makes ninja happy and fixes
incremental builds (and should reduce bot cycle and flake time).

R=dpapad@chromium.org
BUG=none

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2712893002
Cr-Commit-Position: refs/heads/master@{#452389}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec5f9b7821faea7d2083376a934e...
==========

[commit-bot: I haz the power, 2017-02-23 04:21:30]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec5f9b7821faea7d2083376a934e...