Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2712883003: Revert of Rename platform/wtf/ to platform/newwtf/. (Closed)

Created:
3 years, 10 months ago by Yuta Kitamura
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, Mikhail, blink-reviews-wtf_chromium.org, abarth-chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename platform/wtf/ to platform/newwtf/. (patchset #1 id:1 of https://codereview.chromium.org/2706793002/ ) Reason for revert: Turned out this change is not necessary. See comments at https://codereview.chromium.org/2703633003/ Original issue's description: > Rename platform/wtf/ to platform/newwtf/. > > This is unfortunate, but we need to give a different name to platform/wtf/ > to avoid a clang-cl warning regarding MSVC-specific #include search order. > > The details are explained in platform/newwtf/README.md in this change. Also, > the design doc has been amended: > > https://docs.google.com/document/d/1JK26H-1-cD9-s9QLvEfY55H2kgSxRFNPLfjs049Us5w/edit?usp=sharing > > BUG=691465 > > Review-Url: https://codereview.chromium.org/2706793002 > Cr-Commit-Position: refs/heads/master@{#451592} > Committed: https://chromium.googlesource.com/chromium/src/+/35820a2d012cf4d04bac9a571e8052047f336095 TBR=haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=691465 Review-Url: https://codereview.chromium.org/2712883003 Cr-Commit-Position: refs/heads/master@{#452433} Committed: https://chromium.googlesource.com/chromium/src/+/2a5e317098b0b38a990b24743eb072093c7ef634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -69 lines) Patch
D third_party/WebKit/Source/platform/newwtf/DEPS View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/platform/newwtf/OWNERS View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/platform/newwtf/README.md View 1 chunk +0 lines, -25 lines 0 comments Download
A third_party/WebKit/Source/platform/wtf/DEPS View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/wtf/OWNERS View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/wtf/README.md View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/README.md View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yuta Kitamura
Created Revert of Rename platform/wtf/ to platform/newwtf/.
3 years, 10 months ago (2017-02-23 07:45:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712883003/1
3 years, 10 months ago (2017-02-23 07:45:23 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-23 08:21:46 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 08:44:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a5e317098b0b38a990b24743eb0...

Powered by Google App Engine
This is Rietveld 408576698