Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2706793002: Rename platform/wtf/ to platform/newwtf/. (Closed)

Created:
3 years, 10 months ago by Yuta Kitamura
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, Mikhail, blink-reviews-wtf_chromium.org, abarth-chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename platform/wtf/ to platform/newwtf/. This is unfortunate, but we need to give a different name to platform/wtf/ to avoid a clang-cl warning regarding MSVC-specific #include search order. The details are explained in platform/newwtf/README.md in this change. Also, the design doc has been amended: https://docs.google.com/document/d/1JK26H-1-cD9-s9QLvEfY55H2kgSxRFNPLfjs049Us5w/edit?usp=sharing BUG=691465 Review-Url: https://codereview.chromium.org/2706793002 Cr-Commit-Position: refs/heads/master@{#451592} Committed: https://chromium.googlesource.com/chromium/src/+/35820a2d012cf4d04bac9a571e8052047f336095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -58 lines) Patch
A + third_party/WebKit/Source/platform/newwtf/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/newwtf/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/platform/newwtf/README.md View 1 chunk +25 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/wtf/DEPS View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/platform/wtf/OWNERS View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/platform/wtf/README.md View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/README.md View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Yuta Kitamura
haraken, PTAL at this? (This is kind of a sad CL...)
3 years, 10 months ago (2017-02-20 09:21:40 UTC) #4
haraken
On 2017/02/20 09:21:40, Yuta Kitamura wrote: > haraken, PTAL at this? (This is kind of ...
3 years, 10 months ago (2017-02-20 09:27:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706793002/1
3 years, 10 months ago (2017-02-20 10:49:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/35820a2d012cf4d04bac9a571e8052047f336095
3 years, 10 months ago (2017-02-20 10:55:05 UTC) #12
Yuta Kitamura
3 years, 10 months ago (2017-02-23 07:45:05 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2712883003/ by yutak@chromium.org.

The reason for reverting is: Turned out this change is not necessary.

See comments at
https://codereview.chromium.org/2703633003/.

Powered by Google App Engine
This is Rietveld 408576698