Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2712833002: DevTools: Show decoded body length for network requests on timeline. (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, dtapuska+blinkwatch_chromium.org, blink-reviews-events_chromium.org, loading-reviews_chromium.org, eae+blinkwatch, Yoav Weiss, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show decoded body length for network requests on timeline. BUG=695234 Review-Url: https://codereview.chromium.org/2712833002 Cr-Commit-Position: refs/heads/master@{#452902} Committed: https://chromium.googlesource.com/chromium/src/+/3d9da09031192d50f8adde98897536ab85e135e3

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 5 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchContext.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
alph
3 years, 10 months ago (2017-02-22 23:13:03 UTC) #2
caseq
lgtm https://codereview.chromium.org/2712833002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css File third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css (right): https://codereview.chromium.org/2712833002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css#newcode295 third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css:295: max-width: 300px; should this be a part of ...
3 years, 10 months ago (2017-02-23 03:06:00 UTC) #3
pfeldman
lgtm
3 years, 10 months ago (2017-02-24 19:24:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712833002/20001
3 years, 10 months ago (2017-02-24 19:25:00 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 19:31:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d9da09031192d50f8adde988975...

Powered by Google App Engine
This is Rietveld 408576698